fix(logical-assignment): Do not assign names to anonymous functions

babel · Apr 3, 2020 · cbc73c0 · cbc73c0
1 parent 2c31587
commit cbc73c0
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 7 deletions.
diff --git a/packages/babel-plugin-proposal-logical-assignment-operators/src/index.js b/packages/babel-plugin-proposal-logical-assignment-operators/src/index.js
@@ -39,13 +39,26 @@ export default declare(api => {
           }
         }
 
-        path.replaceWith(
-          t.logicalExpression(
-            operator.slice(0, -1),
-            lhs,
-            t.assignmentExpression("=", left, right),
-          ),
-        );
+        const isRHSAnonymousFunction = t.isFunctionExpression(right, {
+          id: null,
+        });
+        if (isRHSAnonymousFunction && operator === "??=") {
+          path.replaceWith(
+            t.assignmentExpression(
+              "=",
+              lhs,
+              t.logicalExpression("??", left, right),
+            ),
+          );
+        } else {
+          path.replaceWith(
+            t.logicalExpression(
+              operator.slice(0, -1),
+              lhs,
+              t.assignmentExpression("=", left, right),
+            ),
+          );
+        }
       },
     },
   };

diff --git a/...logical-assignment-operators/test/fixtures/logical-assignment/anonymous-function/input.js b/...logical-assignment-operators/test/fixtures/logical-assignment/anonymous-function/input.js
@@ -0,0 +1,2 @@
+var f;
+console.log((f ??= function () {}).name);
diff --git a/...cal-assignment-operators/test/fixtures/logical-assignment/anonymous-function/options.json b/...cal-assignment-operators/test/fixtures/logical-assignment/anonymous-function/options.json
@@ -0,0 +1,3 @@
+{
+  "plugins": ["proposal-logical-assignment-operators"]
+}
diff --git a/...ogical-assignment-operators/test/fixtures/logical-assignment/anonymous-function/output.js b/...ogical-assignment-operators/test/fixtures/logical-assignment/anonymous-function/output.js
@@ -0,0 +1,2 @@
+var f;
+console.log((f = f ?? function () {}).name);