Print necessary parentheses in generator

babel · Aug 24, 2022 · d0ded5b · d0ded5b
1 parent dbaf378
commit d0ded5b
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/packages/babel-generator/src/generators/expressions.ts b/packages/babel-generator/src/generators/expressions.ts
@@ -131,14 +131,13 @@ function isDecoratorMemberExpression(
 function shouldParenthesizeDecoratorExpression(
   node: t.Expression | t.Super | t.V8IntrinsicIdentifier,
 ) {
-  if (node.type === "CallExpression") {
-    node = node.callee;
-  }
   if (node.type === "ParenthesizedExpression") {
     // We didn't check extra?.parenthesized here because we don't track decorators in needsParen
     return false;
   }
-  return !isDecoratorMemberExpression(node);
+  return !isDecoratorMemberExpression(
+    node.type === "CallExpression" ? node.callee : node,
+  );
 }
 
 export function Decorator(this: Printer, node: t.Decorator) {

diff --git a/...ures/decorators/decorator-parenthesized-expression-createParenthesizedExpression/input.js b/...ures/decorators/decorator-parenthesized-expression-createParenthesizedExpression/input.js
@@ -9,7 +9,6 @@ class C extends class {} {
       @(this.dec)
       @(super.dec)
       @(new DecFactory)
-      @(decs[three])()
       p;
     }
 
@@ -20,6 +19,11 @@ class C extends class {} {
       p;
     }
 
+    class ShouldAddParens {
+      @(decs[three])()
+      p;
+    }
+
     class WillPreserveParens {
       @(decs)
       @(decs.one)

diff --git a/...res/decorators/decorator-parenthesized-expression-createParenthesizedExpression/output.js b/...res/decorators/decorator-parenthesized-expression-createParenthesizedExpression/output.js
@@ -10,7 +10,6 @@ class C extends class {} {
       @(this.dec)
       @(super.dec)
       @(new DecFactory())
-      @(decs[three])()
       p;
     }
 
@@ -21,6 +20,11 @@ class C extends class {} {
       p;
     }
 
+    class ShouldAddParens {
+      @((decs[three])())
+      p;
+    }
+
     class WillPreserveParens {
       @(decs)
       @(decs.one)