Skip to content

Commit

Permalink
Move side effects from a getter to a function
Browse files Browse the repository at this point in the history
It's just nicer, side effects in getters are surprising.
  • Loading branch information
nicolo-ribaudo committed Mar 9, 2022
1 parent de7eb9f commit d1c7ee5
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions packages/babel-helpers/src/index.ts
Expand Up @@ -253,8 +253,8 @@ interface HelperData {
nodes: t.Program["body"];
globals: string[];
};
minVersion: () => string;
dependencies: Map<t.Identifier, string>;
minVersion: string;
getDependencies: () => string[];
}

const helperData: Record<string, HelperData> = Object.create(null);
Expand Down Expand Up @@ -290,6 +290,7 @@ function loadHelper(name: string) {
let metadata: HelperMetadata | null = null;

helperData[name] = {
minVersion: helper.minVersion,
build(getDependency, id, localBindings) {
const file = fn();
metadata ||= getHelperMetadata(file);
Expand All @@ -300,12 +301,9 @@ function loadHelper(name: string) {
globals: metadata.globals,
};
},
minVersion() {
return helper.minVersion;
},
get dependencies() {
getDependencies() {
metadata ||= getHelperMetadata(fn());
return metadata.dependencies;
return Array.from(metadata.dependencies.values());
},
};
}
Expand All @@ -323,11 +321,11 @@ export function get(
}

export function minVersion(name: string) {
return loadHelper(name).minVersion();
return loadHelper(name).minVersion;
}

export function getDependencies(name: string): ReadonlyArray<string> {
return Array.from(loadHelper(name).dependencies.values());
return loadHelper(name).getDependencies();
}

export function ensure(name: string, newFileClass: typeof File) {
Expand Down

0 comments on commit d1c7ee5

Please sign in to comment.