Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Parse destructuring private fields (#13931)
* feat: parse destructuring private * add test cases * fix: register private name on destructuring * add typings * add syntax plugin * add generator test case * add syntax plugin to preset-stage-2 * fix flow errors * address review comments * fix: use private name in toAssignable * test: add case with undefined refExpressionErrors
- Loading branch information
Showing
61 changed files
with
1,995 additions
and
20 deletions.
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
packages/babel-generator/test/fixtures/types/PrivateName/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
class C { | ||
#x; | ||
m() { | ||
#x in (#x in this); | ||
var { #x: x } = this; | ||
} | ||
} |
3 changes: 3 additions & 0 deletions
3
packages/babel-generator/test/fixtures/types/PrivateName/options.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"plugins": ["destructuringPrivate"] | ||
} |
11 changes: 11 additions & 0 deletions
11
packages/babel-generator/test/fixtures/types/PrivateName/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
class C { | ||
#x; | ||
|
||
m() { | ||
#x in (#x in this); | ||
var { | ||
#x: x | ||
} = this; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
...fixtures/es2022/class-private-properties/invalid-object-property-with-assignment/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
(class { | ||
#x; | ||
m = { | ||
#x: x, | ||
y: y = m | ||
} | ||
}) |
115 changes: 115 additions & 0 deletions
115
...tures/es2022/class-private-properties/invalid-object-property-with-assignment/output.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
{ | ||
"type": "File", | ||
"start":0,"end":53,"loc":{"start":{"line":1,"column":0},"end":{"line":7,"column":2}}, | ||
"errors": [ | ||
"SyntaxError: Unexpected private name. (4:4)" | ||
], | ||
"program": { | ||
"type": "Program", | ||
"start":0,"end":53,"loc":{"start":{"line":1,"column":0},"end":{"line":7,"column":2}}, | ||
"sourceType": "script", | ||
"interpreter": null, | ||
"body": [ | ||
{ | ||
"type": "ExpressionStatement", | ||
"start":0,"end":53,"loc":{"start":{"line":1,"column":0},"end":{"line":7,"column":2}}, | ||
"expression": { | ||
"type": "ClassExpression", | ||
"start":1,"end":52,"loc":{"start":{"line":1,"column":1},"end":{"line":7,"column":1}}, | ||
"id": null, | ||
"superClass": null, | ||
"body": { | ||
"type": "ClassBody", | ||
"start":7,"end":52,"loc":{"start":{"line":1,"column":7},"end":{"line":7,"column":1}}, | ||
"body": [ | ||
{ | ||
"type": "ClassPrivateProperty", | ||
"start":11,"end":14,"loc":{"start":{"line":2,"column":2},"end":{"line":2,"column":5}}, | ||
"static": false, | ||
"key": { | ||
"type": "PrivateName", | ||
"start":11,"end":13,"loc":{"start":{"line":2,"column":2},"end":{"line":2,"column":4}}, | ||
"id": { | ||
"type": "Identifier", | ||
"start":12,"end":13,"loc":{"start":{"line":2,"column":3},"end":{"line":2,"column":4},"identifierName":"x"}, | ||
"name": "x" | ||
} | ||
}, | ||
"value": null | ||
}, | ||
{ | ||
"type": "ClassProperty", | ||
"start":17,"end":50,"loc":{"start":{"line":3,"column":2},"end":{"line":6,"column":3}}, | ||
"static": false, | ||
"key": { | ||
"type": "Identifier", | ||
"start":17,"end":18,"loc":{"start":{"line":3,"column":2},"end":{"line":3,"column":3},"identifierName":"m"}, | ||
"name": "m" | ||
}, | ||
"computed": false, | ||
"value": { | ||
"type": "ObjectExpression", | ||
"start":21,"end":50,"loc":{"start":{"line":3,"column":6},"end":{"line":6,"column":3}}, | ||
"properties": [ | ||
{ | ||
"type": "ObjectProperty", | ||
"start":27,"end":32,"loc":{"start":{"line":4,"column":4},"end":{"line":4,"column":9}}, | ||
"method": false, | ||
"key": { | ||
"type": "PrivateName", | ||
"start":27,"end":29,"loc":{"start":{"line":4,"column":4},"end":{"line":4,"column":6}}, | ||
"id": { | ||
"type": "Identifier", | ||
"start":28,"end":29,"loc":{"start":{"line":4,"column":5},"end":{"line":4,"column":6},"identifierName":"x"}, | ||
"name": "x" | ||
} | ||
}, | ||
"shorthand": false, | ||
"value": { | ||
"type": "Identifier", | ||
"start":31,"end":32,"loc":{"start":{"line":4,"column":8},"end":{"line":4,"column":9},"identifierName":"x"}, | ||
"name": "x" | ||
} | ||
}, | ||
{ | ||
"type": "ObjectProperty", | ||
"start":38,"end":46,"loc":{"start":{"line":5,"column":4},"end":{"line":5,"column":12}}, | ||
"method": false, | ||
"key": { | ||
"type": "Identifier", | ||
"start":38,"end":39,"loc":{"start":{"line":5,"column":4},"end":{"line":5,"column":5},"identifierName":"y"}, | ||
"name": "y" | ||
}, | ||
"computed": false, | ||
"shorthand": false, | ||
"value": { | ||
"type": "AssignmentExpression", | ||
"start":41,"end":46,"loc":{"start":{"line":5,"column":7},"end":{"line":5,"column":12}}, | ||
"operator": "=", | ||
"left": { | ||
"type": "Identifier", | ||
"start":41,"end":42,"loc":{"start":{"line":5,"column":7},"end":{"line":5,"column":8},"identifierName":"y"}, | ||
"name": "y" | ||
}, | ||
"right": { | ||
"type": "Identifier", | ||
"start":45,"end":46,"loc":{"start":{"line":5,"column":11},"end":{"line":5,"column":12},"identifierName":"m"}, | ||
"name": "m" | ||
} | ||
} | ||
} | ||
] | ||
} | ||
} | ||
] | ||
}, | ||
"extra": { | ||
"parenthesized": true, | ||
"parenStart": 0 | ||
} | ||
} | ||
} | ||
], | ||
"directives": [] | ||
} | ||
} |
Oops, something went wrong.