review

babel · Nov 16, 2023 · dd62739 · dd62739
1 parent 6223fa1
commit dd62739
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 9 deletions.
diff --git a/packages/babel-generator/src/printer.ts b/packages/babel-generator/src/printer.ts
@@ -664,20 +664,33 @@ class Printer {
     this._insideAux = node.loc == undefined;
     this._maybeAddAuxComment(this._insideAux && !oldInAux);
 
+    const parenthesized = node.extra?.parenthesized as boolean | undefined;
     let shouldPrintParens =
       forceParens ||
-      (format.retainFunctionParens &&
-        nodeType === "FunctionExpression" &&
-        node.extra?.parenthesized) ||
+      (parenthesized &&
+        format.retainFunctionParens &&
+        nodeType === "FunctionExpression") ||
       needsParens(node, parent, this._printStack);
 
     if (
       !shouldPrintParens &&
-      parent?.type === "MemberExpression" &&
-      node.extra?.parenthesized &&
-      node.leadingComments?.length
+      parenthesized &&
+      node.leadingComments?.length &&
+      node.leadingComments[0].type === "CommentBlock"
     ) {
-      shouldPrintParens = true;
+      const parentType = parent?.type;
+      switch (parentType) {
+        case "ExpressionStatement":
+        case "VariableDeclarator":
+        case "AssignmentExpression":
+        case "ReturnStatement":
+        case "CallExpression":
+        case "OptionalCallExpression":
+        case "NewExpression":
+          break;
+        default:
+          shouldPrintParens = true;
+      }
     }
 
     if (shouldPrintParens) {

diff --git a/packages/babel-generator/test/fixtures/comments/pure-in-member-expression/input.js b/packages/babel-generator/test/fixtures/comments/pure-in-member-expression/input.js
diff --git a/packages/babel-generator/test/fixtures/comments/pure-in-member-expression/output.js b/packages/babel-generator/test/fixtures/comments/pure-in-member-expression/output.js
diff --git a/packages/babel-generator/test/fixtures/comments/pure-in-paren/input.js b/packages/babel-generator/test/fixtures/comments/pure-in-paren/input.js
@@ -0,0 +1,4 @@
+(/* @__PURE__ */ f()).g();
+(/* @__PURE__ */ f())();
+(/* @__PURE__ */ f())?.bar;
+(/* @__PURE__ */ f())`bar`;
diff --git a/packages/babel-generator/test/fixtures/comments/pure-in-paren/output.js b/packages/babel-generator/test/fixtures/comments/pure-in-paren/output.js
@@ -0,0 +1,4 @@
+( /* @__PURE__ */f()).g();
+/* @__PURE__ */f()();
+( /* @__PURE__ */f())?.bar;
+( /* @__PURE__ */f())`bar`;