fix: don't elide jsx pragma import namespaces (#11523)

* fix: don't elide jsx pragma import namespaces * use the correct pragma oops
babel · May 14, 2020 · de8264c · de8264c
1 parent 9a52019
commit de8264c
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 1 deletion.
diff --git a/packages/babel-plugin-transform-typescript/src/index.js b/packages/babel-plugin-transform-typescript/src/index.js
@@ -169,6 +169,11 @@ export default declare(
             }
           }
 
+          let pragmaImportName = fileJsxPragma || jsxPragma;
+          if (pragmaImportName) {
+            [pragmaImportName] = pragmaImportName.split(".");
+          }
+
           // remove type imports
           for (let stmt of path.get("body")) {
             if (t.isImportDeclaration(stmt)) {
@@ -203,7 +208,7 @@ export default declare(
                     isImportTypeOnly({
                       binding,
                       programPath: path,
-                      jsxPragma: fileJsxPragma || jsxPragma,
+                      jsxPragma: pragmaImportName,
                     })
                   ) {
                     importsToRemove.push(binding.path);

diff --git a/...-plugin-transform-typescript/test/fixtures/imports/elide-jsx-pragma-namespace-no/input.ts b/...-plugin-transform-typescript/test/fixtures/imports/elide-jsx-pragma-namespace-no/input.ts
@@ -0,0 +1,4 @@
+/* @jsx jsx.htm */
+// Don't elide htm if a JSX element appears somewhere.
+import * as jsx from "fake-jsx-package";
+<div></div>;
diff --git a/...gin-transform-typescript/test/fixtures/imports/elide-jsx-pragma-namespace-no/options.json b/...gin-transform-typescript/test/fixtures/imports/elide-jsx-pragma-namespace-no/options.json
@@ -0,0 +1,3 @@
+{
+  "plugins": [["transform-typescript", { "isTSX": true }]]
+}
diff --git a/...lugin-transform-typescript/test/fixtures/imports/elide-jsx-pragma-namespace-no/output.mjs b/...lugin-transform-typescript/test/fixtures/imports/elide-jsx-pragma-namespace-no/output.mjs
@@ -0,0 +1,4 @@
+/* @jsx jsx.htm */
+// Don't elide htm if a JSX element appears somewhere.
+import * as jsx from "fake-jsx-package";
+<div></div>;