Skip to content

Commit

Permalink
Exclude import() tests from pubilsh build
Browse files Browse the repository at this point in the history
I really don't like this commit, but import() is currently breaking
our publish script.
When "normal" tests we are transpiling import() so that it works
with Jest. We can't do it while publishing because we need to
publish the untranspiled import() so that it can load real .mjs files.

Follow up to #10903
  • Loading branch information
nicolo-ribaudo committed Jan 13, 2020
1 parent d0a8982 commit e3cf12d
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Expand Up @@ -212,7 +212,7 @@ prepublish-build: clean-lib clean-runtime-helpers
prepublish:
$(MAKE) bootstrap-only
$(MAKE) prepublish-build
$(MAKE) test
IS_PUBLISH=true $(MAKE) test

new-version:
git pull --rebase
Expand Down
30 changes: 30 additions & 0 deletions packages/babel-core/test/config-chain.js
Expand Up @@ -1044,6 +1044,10 @@ describe("buildConfigChain", function() {
);
const filename = tmp("src.js");

// We can't transpile import() while publishing, and it isn't supported
// by jest.
if (process.env.IS_PUBLISH && name === "babel.config.mjs") return;

await config(name);

expect(await loadOptionsAsync({ filename, cwd })).toEqual({
Expand All @@ -1067,6 +1071,15 @@ describe("buildConfigChain", function() {
`babel-test-dup-config-${name1}-${name2}`,
);

// We can't transpile import() while publishing, and it isn't supported
// by jest.
if (
process.env.IS_PUBLISH &&
(name1 === "babel.config.mjs" || name2 === "babel.config.mjs")
) {
return;
}

await Promise.all([config(name1), config(name2)]);

await expect(
Expand Down Expand Up @@ -1124,6 +1137,10 @@ describe("buildConfigChain", function() {
);
const filename = tmp("src.js");

// We can't transpile import() while publishing, and it isn't supported
// by jest.
if (process.env.IS_PUBLISH && name === ".babelrc.mjs") return;

await config(name);

expect(await loadOptionsAsync({ filename, cwd })).toEqual({
Expand Down Expand Up @@ -1157,6 +1174,15 @@ describe("buildConfigChain", function() {
`babel-test-dup-config-${name1}-${name2}`,
);

// We can't transpile import() while publishing, and it isn't supported
// by jest.
if (
process.env.IS_PUBLISH &&
(name1 === ".babelrc.mjs" || name2 === ".babelrc.mjs")
) {
return;
}

await Promise.all([config(name1), config(name2)]);

await expect(
Expand Down Expand Up @@ -1187,6 +1213,10 @@ describe("buildConfigChain", function() {
`("should show helpful errors for $config", async ({ dir, error }) => {
const filename = fixture("config-files", dir, "src.js");

// We can't transpile import() while publishing, and it isn't supported
// by jest.
if (process.env.IS_PUBLISH && dir === "babelrc-mjs-error") return;

await expect(
loadOptionsAsync({ filename, cwd: path.dirname(filename) }),
).rejects.toThrow(error);
Expand Down

0 comments on commit e3cf12d

Please sign in to comment.