Don't allow instance properties transformation on namespace for `usag…

…e` plugin
babel · Sep 1, 2019 · f4f1e4c · f4f1e4c
1 parent 7b441bb
commit f4f1e4c
Show file tree

Hide file tree

Showing 9 changed files with 47 additions and 2 deletions.
diff --git a/packages/babel-preset-env/src/polyfills/corejs2/usage-plugin.js b/packages/babel-preset-env/src/polyfills/corejs2/usage-plugin.js
@@ -15,6 +15,7 @@ import {
   isPolyfillSource,
   getImportSource,
   getRequireSource,
+  isNamespaced,
 } from "../../utils";
 import { logUsagePolyfills } from "../../debug";
 
@@ -102,6 +103,9 @@ export default function(
         const { node } = path;
         const { object, property } = node;
 
+        // ignore namespace
+        if (isNamespaced(path.get("object"))) return;
+
         let evaluatedPropType = object.name;
         let propertyName = property.name;
         let instanceType = "";

diff --git a/packages/babel-preset-env/src/polyfills/corejs3/usage-plugin.js b/packages/babel-preset-env/src/polyfills/corejs3/usage-plugin.js
@@ -21,6 +21,7 @@ import {
   isPolyfillSource,
   getImportSource,
   getRequireSource,
+  isNamespaced,
 } from "../../utils";
 import { logUsagePolyfills } from "../../debug";
 
@@ -98,7 +99,7 @@ export default function(
         }
       }
     }
-    return { builtIn, instanceType };
+    return { builtIn, instanceType, isNamespaced: isNamespaced(path) };
   }
 
   const addAndRemovePolyfillImports = {
@@ -230,7 +231,8 @@ export default function(
       };
 
       this.addPropertyDependencies = function(source = {}, key) {
-        const { builtIn, instanceType } = source;
+        const { builtIn, instanceType, isNamespaced } = source;
+        if (isNamespaced) return;
         if (PossibleGlobalObjects.has(builtIn)) {
           this.addBuiltInDependencies(key);
         } else if (has(StaticProperties, builtIn)) {

diff --git a/packages/babel-preset-env/src/utils.js b/packages/babel-preset-env/src/utils.js
@@ -162,3 +162,9 @@ export function getModulePath(mod: string): string {
 export function createImport(path: NodePath, mod: string) {
   return addSideEffect(path, getModulePath(mod));
 }
+
+export function isNamespaced(path: NodePath) {
+  const binding = path.scope.getBinding(path.node.name);
+  if (!binding) return false;
+  return binding.path.isImportNamespaceSpecifier();
+}
diff --git a/packages/babel-preset-env/test/fixtures/corejs2/usage-modules-namespaced/input.mjs b/packages/babel-preset-env/test/fixtures/corejs2/usage-modules-namespaced/input.mjs
@@ -0,0 +1,2 @@
+import * as ns from "ns";
+ns.map;
diff --git a/packages/babel-preset-env/test/fixtures/corejs2/usage-modules-namespaced/options.json b/packages/babel-preset-env/test/fixtures/corejs2/usage-modules-namespaced/options.json
@@ -0,0 +1,12 @@
+{
+  "presets": [
+    [
+      "../../../../lib",
+      {
+        "modules": false,
+        "useBuiltIns": "usage",
+        "corejs": 2
+      }
+    ]
+  ]
+}
diff --git a/packages/babel-preset-env/test/fixtures/corejs2/usage-modules-namespaced/output.mjs b/packages/babel-preset-env/test/fixtures/corejs2/usage-modules-namespaced/output.mjs
@@ -0,0 +1,3 @@
+import * as ns from "ns";
+ns.map;
+
diff --git a/packages/babel-preset-env/test/fixtures/corejs3/usage-modules-namespaced/input.mjs b/packages/babel-preset-env/test/fixtures/corejs3/usage-modules-namespaced/input.mjs
@@ -0,0 +1,2 @@
+import * as ns from "ns";
+ns.map;
diff --git a/packages/babel-preset-env/test/fixtures/corejs3/usage-modules-namespaced/options.json b/packages/babel-preset-env/test/fixtures/corejs3/usage-modules-namespaced/options.json
@@ -0,0 +1,12 @@
+{
+  "presets": [
+    [
+      "../../../../lib",
+      {
+        "modules": false,
+        "useBuiltIns": "usage",
+        "corejs": 3
+      }
+    ]
+  ]
+}
diff --git a/packages/babel-preset-env/test/fixtures/corejs3/usage-modules-namespaced/output.mjs b/packages/babel-preset-env/test/fixtures/corejs3/usage-modules-namespaced/output.mjs
@@ -0,0 +1,2 @@
+import * as ns from "ns";
+ns.map;