update: hardcode @babel/eslint-parser min supported version check (#1…

…1896) * update: change babel-eslint-parser version mismatch error to log * Bump @babel/core version * Change to 7.2.0 * Add period to error message
babel · Jul 30, 2020 · f7ec170 · f7ec170
1 parent db56261
commit f7ec170
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/eslint/babel-eslint-parser/package.json b/eslint/babel-eslint-parser/package.json
@@ -23,7 +23,7 @@
     "./package.json": "./package.json"
   },
   "peerDependencies": {
-    "@babel/core": ">=7.10.0",
+    "@babel/core": ">=7.11.0",
     "eslint": ">=7.5.0"
   },
   "dependencies": {

diff --git a/eslint/babel-eslint-parser/src/index.js b/eslint/babel-eslint-parser/src/index.js
@@ -12,19 +12,22 @@ import convert from "./convert";
 import analyzeScope from "./analyze-scope";
 import visitorKeys from "./visitor-keys";
 
-let isRunningSupportedVersion;
+let isRunningMinSupportedCoreVersion = null;
 
 function baseParse(code, options) {
-  if (typeof isRunningSupportedVersion !== "boolean") {
-    isRunningSupportedVersion = semver.satisfies(
+  // Ensure we're using a version of `@babel/core` that includes `parse()` and `tokTypes`.
+  const minSupportedCoreVersion = ">=7.2.0";
+
+  if (typeof isRunningMinSupportedCoreVersion !== "boolean") {
+    isRunningMinSupportedCoreVersion = semver.satisfies(
       babelCoreVersion,
-      packageJson.peerDependencies["@babel/core"],
+      minSupportedCoreVersion,
     );
   }
 
-  if (!isRunningSupportedVersion) {
+  if (!isRunningMinSupportedCoreVersion) {
     throw new Error(
-      `@babel/eslint-parser@${packageJson.version} does not support @babel/core@${babelCoreVersion}. Please upgrade to @babel/core@${packageJson.peerDependencies["@babel/core"]}`,
+      `@babel/eslint-parser@${packageJson.version} does not support @babel/core@${babelCoreVersion}. Please upgrade to @babel/core@${minSupportedCoreVersion}.`,
     );
   }