@babel/eslint-parser: fix ImportExpression node to match ESTree spec

babel · Dec 6, 2019 · f83e53f · f83e53f
1 parent c9a6898
commit f83e53f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/eslint/babel-eslint-parser/test/babel-eslint-parser.js b/eslint/babel-eslint-parser/test/babel-eslint-parser.js
@@ -27,7 +27,7 @@ function parseAndAssertSame(code) {
     loc: true,
     range: true,
     comment: true,
-    ecmaVersion: 2018,
+    ecmaVersion: 2020,
     sourceType: "module",
   });
   const babylonAST = parseForESLint(code, {
@@ -518,5 +518,11 @@ describe("babylon-to-espree", () => {
         }
       `);
     });
+
+    it("Dynamic Import", () => {
+      parseAndAssertSame(`
+        const a = import('a');
+      `);
+    });
   });
 });
diff --git a/packages/babel-parser/src/parser/expression.js b/packages/babel-parser/src/parser/expression.js
@@ -785,6 +785,7 @@ export default class ExpressionParser extends LValParser {
     node: T,
     optional: boolean,
   ): T {
+    let nodeType = optional ? "OptionalCallExpression" : "CallExpression";
     if (node.callee.type === "Import") {
       if (node.arguments.length !== 1) {
         this.raise(node.start, "import() requires exactly one argument");
@@ -794,11 +795,12 @@ export default class ExpressionParser extends LValParser {
           this.raise(importArg.start, "... is not allowed in import()");
         }
       }
+
+      if (this.hasPlugin("estree")) {
+        nodeType = "ImportExpression";
+      }
     }
-    return this.finishNode(
-      node,
-      optional ? "OptionalCallExpression" : "CallExpression",
-    );
+    return this.finishNode(node, nodeType);
   }
 
   parseCallExpressionArguments(