Skip to content

Commit

Permalink
Fix create-react-app and vue-cli tests on Node.js 17 (#13879)
Browse files Browse the repository at this point in the history
* Fix `create-react-app` and `vue-cli` tests on Node.js 17

* Only on Node 17

* Fix
  • Loading branch information
nicolo-ribaudo committed Oct 25, 2021
1 parent c7ddb1a commit ff92296
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
5 changes: 5 additions & 0 deletions scripts/integration-tests/e2e-create-react-app.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ do
(cd "$d"; node "$bump_deps")
done

if [[ "$(node --version)" == v17.* ]]; then
# Remove this when https://github.com/webpack/webpack/issues/14532 is fixed
export NODE_OPTIONS=--openssl-legacy-provider
fi

startLocalRegistry "$PWD"/../../verdaccio-config.yml
npm install

Expand Down
9 changes: 7 additions & 2 deletions scripts/integration-tests/e2e-vue-cli.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,15 @@ cd tmp/vue-cli || exit
export YARN_IGNORE_PATH=1

startLocalRegistry "$PWD"/../../verdaccio-config.yml
yarn install
yarn install --ignore-engines # Remove --ignore-engines when vue-cli upgrades their lockfile to eslint-import-resolver-webpack@0.13.2
node "$PWD"/../../utils/bump-babel-dependencies.js
yarn lerna exec -- node "$PWD"/../../utils/bump-babel-dependencies.js
yarn install
yarn install --ignore-engines # Remove --ignore-engines when vue-cli upgrades their lockfile to eslint-import-resolver-webpack@0.13.2

if [[ "$(node --version)" == v17.* ]]; then
# Remove this when https://github.com/webpack/webpack/issues/14532 is fixed
export NODE_OPTIONS=--openssl-legacy-provider
fi

# Test
CI=true yarn test -p babel,babel-preset-app
Expand Down

0 comments on commit ff92296

Please sign in to comment.