Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken build after source-map was bumped to v0.6 #10533

Closed
andreineculau opened this issue Oct 9, 2019 · 2 comments · Fixed by #10536
Closed

broken build after source-map was bumped to v0.6 #10533

andreineculau opened this issue Oct 9, 2019 · 2 comments · Fixed by #10536
Labels
area: sourcemaps i: bug i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@andreineculau
Copy link

Bug Report

Current Behavior

Getting the following when running babel CLI, after babel@7.6.3 was picked up (which includes a newer source-map #10446 ):
Travis CI build

Error: original.line and original.column are not numbers -- you probably meant to omit the original mapping entirely and only map the generated position. If so, pass null for the original mapping instead of an object with empty or null values.
393    at SourceMapGenerator_validateMapping [as _validateMapping] (/home/travis/build/tobiipro/browser-coords/node_modules/@babel/cli/node_modules/source-map/lib/source-map-generator.js:276:15)
394    at SourceMapGenerator_addMapping [as addMapping] (/home/travis/build/tobiipro/browser-coords/node_modules/@babel/cli/node_modules/source-map/lib/source-map-generator.js:110:12)
395    at /home/travis/build/tobiipro/browser-coords/node_modules/@babel/cli/lib/babel/file.js:106:17
396    at Array.forEach (<anonymous>)
397    at BasicSourceMapConsumer.SourceMapConsumer_eachMapping [as eachMapping] (/home/travis/build/tobiipro/browser-coords/node_modules/@babel/cli/node_modules/source-map/lib/source-map-consumer.js:157:14)
398    at buildResult (/home/travis/build/tobiipro/browser-coords/node_modules/@babel/cli/lib/babel/file.js:104:20)
399    at output (/home/travis/build/tobiipro/browser-coords/node_modules/@babel/cli/lib/babel/file.js:140:22)
400    at /home/travis/build/tobiipro/browser-coords/node_modules/@babel/cli/lib/babel/file.js:236:9
401    at Generator.next (<anonymous>)
402    at asyncGeneratorStep (/home/travis/build/tobiipro/browser-coords/node_modules/@babel/cli/lib/babel/file.js:76:103)

Input Code

https://github.com/tobiipro/browser-coords

Expected behavior/code

A green build, like the previous one with babel@7.6.2 .

Babel Configuration (.babelrc, package.json, cli command)

module.exports = {
  presets: [
    ['firecloud', {
      '@babel/preset-env': {
        targets: {
          browsers: [
            'last 2 Chrome versions'
          ]
        }
      }
    }]
  ],

  sourceMaps: true,

  retainLines: true
};

Environment

  • Babel version(s): 7.6.3
  • Node/npm version: Node 10+
  • OS: any
  • Monorepo: no
  • How you are using Babel: cli

Possible Solution

Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

@babel-bot
Copy link
Collaborator

Hey @andreineculau! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

@medikoo
Copy link

medikoo commented Oct 10, 2019

Same here, perfectly working build stopped working

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: sourcemaps i: bug i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants