Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Babel bug #295

Merged
merged 1 commit into from Oct 10, 2019
Merged

Workaround Babel bug #295

merged 1 commit into from Oct 10, 2019

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 10, 2019

After upgrade to babel @7.6.3 build step stopped working -> https://travis-ci.com/serverless/enterprise-plugin/jobs/244182734

It's due to: babel/babel#10533

Fix babel to 7.6.2 for a meantime

@medikoo medikoo self-assigned this Oct 10, 2019
@medikoo medikoo changed the title Workaround babel bug Workaround Babel bug Oct 10, 2019
@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #295 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   56.81%   56.81%           
=======================================
  Files          92       92           
  Lines        2408     2408           
=======================================
  Hits         1368     1368           
  Misses       1040     1040

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b6f4e...434eff8. Read the comment docs.

@medikoo medikoo requested a review from dschep October 10, 2019 12:47
Copy link
Contributor

@dschep dschep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh.. a patch release caused this? Is babel not semver?

@medikoo
Copy link
Contributor Author

medikoo commented Oct 10, 2019

Ugh.. a patch release caused this? Is babel not semver?

I assume that breakage was unintended, but somehow it sneaked the review.

@medikoo medikoo merged commit 95d1d2c into master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants