Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover accessorIsGenerator with generator: true #11986

Closed
1 task
fisker opened this issue Aug 21, 2020 · 1 comment · Fixed by #11987
Closed
1 task

Recover accessorIsGenerator with generator: true #11986

fisker opened this issue Aug 21, 2020 · 1 comment · Fixed by #11987
Labels
i: enhancement outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@fisker
Copy link
Contributor

fisker commented Aug 21, 2020

Feature Request

  • I would like to work on this feature!

Is your feature request related to a problem?

#11921 add recoverable error on accessorIsGenerator

{get *iterator() { }}

Describe the solution you'd like

The ObjectMethod node property generator is set to false. If we can set generator to true, it will be easier for Prettier to known that * is used.

Context: prettier/prettier#8947 (comment)

Describe alternatives you've considered.

Na

Documentation, Adoption, Migration Strategy

Na

@JLHwung

@babel-bot
Copy link
Collaborator

Hey @fisker! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: enhancement outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants