Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set generator to true during error recovery of accessor #11987

Merged
merged 1 commit into from Aug 21, 2020
Merged

Set generator to true during error recovery of accessor #11987

merged 1 commit into from Aug 21, 2020

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented Aug 21, 2020 •
edited

Q                       A
Fixed Issues? Fixes #11986
Patch: Bug Fix? Y
Tests Added + Pass? Yes
License MIT

Ref: prettier/prettier#8947

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser labels Aug 21, 2020
@existentialism existentialism mentioned this pull request Aug 21, 2020
Merged
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27729/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a2170b8:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@fisker
Copy link
Contributor

fisker commented Aug 21, 2020

Thank you! @existentialism

@existentialism existentialism merged commit 941f610 into main Aug 21, 2020
@existentialism existentialism deleted the issue11986 branch August 21, 2020 19:37
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recover accessorIsGenerator with generator: true
5 participants
@existentialism @babel-bot @fisker @JLHwung @nicolo-ribaudo