Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useBuiltIns option for react-jsx #4627

Closed
klimashkin opened this issue Oct 1, 2016 · 3 comments
Closed

useBuiltIns option for react-jsx #4627

klimashkin opened this issue Oct 1, 2016 · 3 comments
Labels
help wanted i: enhancement outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@klimashkin
Copy link

Property spread in jsx tags doesn't support useBuiltIns option as transform-object-rest-spread does.
Would be great to have it in jsx too, to eliminate babel-runtime/helpers/extends from result bundle completely.
@hzoo
Copy link
Member

hzoo commented Oct 1, 2016 •
edited

The previous PR was #4491

It's done in https://github.com/babel/babel/blob/master/packages/babel-helper-builder-react-jsx/src/index.js#L159

@existentialism existentialism mentioned this issue Oct 3, 2016
Merged
@danez
Copy link
Member

danez commented Oct 14, 2016

Fixed by #4655

@danez danez closed this as completed Oct 14, 2016
@hzoo
Copy link
Member

hzoo commented Oct 24, 2016

http://babeljs.io/blog/2016/10/24/6.18.0

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted i: enhancement outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danez @klimashkin @hzoo