Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add useBuiltIns option to helper-builder-react-jsx #4655

Merged
merged 1 commit into from Oct 14, 2016
Merged

Add useBuiltIns option to helper-builder-react-jsx #4655

merged 1 commit into from Oct 14, 2016

Conversation

existentialism
Copy link
Member

Q A
Bug fix? no
Breaking change? no
New feature? yes
Deprecations? no
Spec compliancy? no
Tests added/pass? yes/yes
Fixed tickets #4627
License MIT
Doc PR --

@codecov-io
Copy link

codecov-io commented Oct 3, 2016 •
edited

Current coverage is 88.83% (diff: 100%)

No coverage report found for master at 09f135f.

Powered by Codecov. Last update 09f135f...5405a36

@hzoo hzoo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Oct 3, 2016
hzoo
hzoo approved these changes Oct 5, 2016
View reviewed changes
Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loganfsmyth?

This is for transform-react-jsx but we implement it inside of babel-helper-builder-react-jsx and use file.opts.useBuiltIns

@hzoo
Copy link
Member

hzoo commented Oct 7, 2016

@danez good? ref #4491

@danez danez merged commit fde16f1 into babel:master Oct 14, 2016
@danez danez mentioned this pull request Oct 14, 2016
Closed
@existentialism existentialism deleted the usebuiltins-jsx branch October 14, 2016 19:22
chrisprice pushed a commit to chrisprice/babel that referenced this pull request Oct 18, 2016
@existentialism @chrisprice
Add useBuiltIns option to helper-builder-react-jsx (babel#4655)
4776e78
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@existentialism @panagosg7
Add useBuiltIns option to helper-builder-react-jsx (babel#4655)
f3fa66f
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hzoo hzoo hzoo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@existentialism @codecov-io @hzoo @danez