Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for #5162 #5163

Closed
4 tasks
loganfsmyth opened this issue Jan 20, 2017 · 4 comments · Fixed by #5342
Closed
4 tasks

Write tests for #5162 #5163

loganfsmyth opened this issue Jan 20, 2017 · 4 comments · Fixed by #5342
Labels
good first issue Has PR help wanted outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@loganfsmyth
Copy link
Member

loganfsmyth commented Jan 20, 2017 •
edited by hzoo

Fixed the code in that case, but we should add a test to make sure it doesn't regress.
@loganfsmyth loganfsmyth mentioned this issue Jan 20, 2017
Merged
@mswiecicki
Copy link
Contributor

I could help with that.

I'd just need to now what babel's testing stack looks like (i only have experience with jasmine)

@existentialism
Copy link
Member

existentialism commented Jan 20, 2017 •
edited

@4rlekin check out CONTRIBUTING for some notes about running tests.

The existing babel-node tests should serve as a great starting point, especially the filename test.

@outsideris
Copy link
Contributor

Is it working on progress? If not, I could handle this.

@mswiecicki
Copy link
Contributor

@outsideris oh shoot, i forgot about the matter, you are very welcome to pick things up

outsideris added a commit to outsideris/babel that referenced this issue Feb 19, 2017
@outsideris
Add test for passing arguments to babel-node (babel#5163)
0f8e104
@outsideris outsideris mentioned this issue Feb 19, 2017
Merged
hzoo pushed a commit that referenced this issue Feb 22, 2017
@outsideris @hzoo
Add test for passing arguments to babel-node (#5163) (#5342)
2de4b08
existentialism pushed a commit that referenced this issue May 19, 2017
@outsideris @existentialism
Add test for passing arguments to babel-node (#5163) (#5342)
fc2fbc2
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Has PR help wanted outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test for passing arguments to babel-node (#5163) outsideris/babel
5 participants
@existentialism @loganfsmyth @outsideris @mswiecicki @babel-bot