Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for passing arguments to babel-node (#5163) #5342

Merged
merged 1 commit into from Feb 22, 2017

Conversation

outsideris
Copy link
Contributor

Q A
Patch: Bug Fix? N
Major: Breaking Change? N
Minor: New Feature? N
Deprecations?
Spec Compliancy?
Tests Added/Pass? Y
Fixed Tickets close #5163
License MIT
Doc PR
Dependency Changes

This PR is adding a test for passing arguments to babel-node which is addressed by #5162 . I checked it pass the test case and it is failed when I revert the changes of #5162 .

I not sure the test folder name is properly because it's my first PR on babel. Let me know if I miss something.

@codecov-io
Copy link

Codecov Report

Merging #5342 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5342   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files         204      204           
  Lines        9949     9949           
  Branches     2689     2689           
=======================================
  Hits         8899     8899           
  Misses       1050     1050

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07dd2b1...0f8e104. Read the comment docs.

Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me 👍

The V8 flags passed from babel-node are mostly untested (see coverage)

@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Feb 22, 2017
@hzoo
Copy link
Member

hzoo commented Feb 22, 2017

Awesome!

@hzoo hzoo merged commit 2de4b08 into babel:master Feb 22, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for #5162
4 participants