Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the F# pipeline operator #10028

Merged
merged 2 commits into from Jun 30, 2019

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented May 25, 2019

This PR includes #9450 and #9984, which were not merged to master but to a separate branch. They have already been approved.

⚠️⚠️⚠️ Note to myself (or whoever will merge this PR)
Do not use "Squash and merge", to keep both @thiagoarrais and @mAAdhaTTah as the authors.

@nicolo-ribaudo nicolo-ribaudo changed the title Feature 7.5.0/fsharp pipeline Parse + transform F# pipeline operator May 25, 2019
@nicolo-ribaudo nicolo-ribaudo changed the title Parse + transform F# pipeline operator Add support for the F# pipeline operator May 25, 2019
@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: Pipeline Operator labels May 25, 2019
@nicolo-ribaudo nicolo-ribaudo added this to the v7.5.0 milestone May 25, 2019
mAAdhaTTah and others added 2 commits May 25, 2019 12:56
* Transform for F#-style await

Inludes support for optimizing single-parameter arrow functions

* Wait until optimization before pushing placeholder into scope
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10864/

@Sceat
Copy link

Sceat commented Jun 1, 2019

@nicolo-ribaudo any ETA ? 🚀

@mAAdhaTTah
Copy link
Contributor

@Sceat F# is targeted for babel v7.5.0. I don't know as there is a specific timeline for that, but it'll go in when the team has decided they're ready to cut the next minor release.

@benjamn
Copy link
Contributor

benjamn commented Jun 18, 2019

Does this need to be blocking v7.5.0? Or is it close to getting reviewed/approved? I would offer to review, but I don't have a very deep understanding of the pipeline operator proposal.

@mAAdhaTTah
Copy link
Contributor

@benjamn This is done–reviewed and approved already. It's just waiting for the timing of v7.5.0, which should be sometime within the next week or two.

@thiagoarrais
Copy link
Contributor

Related: babel/website#2049

@nicolo-ribaudo nicolo-ribaudo merged commit a4170b5 into master Jun 30, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the feature-7.5.0/fsharp-pipeline branch June 30, 2019 12:01
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: Pipeline Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants