Refactor isImportTypeOnly helper function #10047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
May 30, 2019
| @@ -39,16 +34,15 @@ export default declare((api, { jsxPragma = "React" }) => { | |||
| Identifier: visitPattern, | |||
| RestElement: visitPattern, | |||
|
|
|||
| Program(path, state: State) { | |||
| state.programPath = path; | |||
There was a problem hiding this comment.
this was some leftover, not used anymore
Andarist
commented
May 30, 2019
|
|
||
| if (file.ast.comments) { | ||
| for (const comment of (file.ast.comments: Array<Object>)) { | ||
| const jsxMatches = JSX_ANNOTATION_REGEX.exec(comment.value); | ||
| if (jsxMatches) { | ||
| file.set(PRAGMA_KEY, jsxMatches[1]); | ||
| fileJsxPragma = jsxMatches[1]; |
There was a problem hiding this comment.
Instead of storing this in a shared mutable state under some artificial key I think it's better to just pass it as explicit argument to isImportTypeOnly, as it makes the data flow clearer - especially that this info doesn't have to be passed through layers of functions, it's needed just one 1 level lower.
existentialism
added
the
PR: Polish 💅
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10895/ |
existentialism
approved these changes
May 30, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've bumped onto the issue fixed by this because I had outdated dependencies, was reading the code and noticed those few small things that could be improved so I've prepared this small PR.