Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add parameter default test to renamer #10055

Closed
wants to merge 13 commits into from
Closed

test: add parameter default test to renamer #10055

wants to merge 13 commits into from

Commits on Jul 16, 2019

  1. test: add parameter default test to renamer

    @JLHwung
    JLHwung committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    db27df0 View commit details
    Browse the repository at this point in the history

  2. test: another edge case test

    @JLHwung
    JLHwung committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    7e90c7d View commit details
    Browse the repository at this point in the history

  3. fix(renamer): check parameter default outer binding 

    When the scope path is a function declaration, check possible outer bindings in the default parameter assignment expression. They should not be renamed in this case.
    @JLHwung
    JLHwung committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    46d6c14 View commit details
    Browse the repository at this point in the history

  4. fix(renamer): add test on parameter default identifier case

    @JLHwung
    JLHwung committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    4f99c9d View commit details
    Browse the repository at this point in the history

  5. fix(renamer): traverse param for assignment pattern

    @JLHwung
    JLHwung committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    49ddbd9 View commit details
    Browse the repository at this point in the history

  6. fix(renamer): check computedProperty in paramHasOuterBinding

    @JLHwung
    JLHwung committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    5053042 View commit details
    Browse the repository at this point in the history

  7. test: add mixed cases

    @JLHwung
    JLHwung committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    34fb047 View commit details
    Browse the repository at this point in the history

  8. fix: do not skip new scope so that the nested referenced identifier c… 

    …an be checked
    @JLHwung
    JLHwung committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    9742b0e View commit details
    Browse the repository at this point in the history

  9. test: two true negative case introduced from last commit

    @JLHwung
    JLHwung committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    a8ff216 View commit details
    Browse the repository at this point in the history

  10. test: add case where rename happens on isolated scope default parameter

    @JLHwung
    JLHwung committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    90c0151 View commit details
    Browse the repository at this point in the history

  11. fix: getBinding return incorrect binding on parameter scope

    @JLHwung
    JLHwung committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    9972a5d View commit details
    Browse the repository at this point in the history

  12. fix: check default parameter in rename visitor

    @JLHwung
    JLHwung committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    ae0e42b View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2019

  1. refactor: simplify logic

    @JLHwung
    JLHwung committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    4151066 View commit details
    Browse the repository at this point in the history