Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compat-table and updating preset-env mappings #10127

Merged
merged 1 commit into from Jul 3, 2019
Merged

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented Jun 25, 2019

Q                       A
Fixed Issues? Fixes #6605
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Y/Y
Documentation PR Link
Any Dependency Changes?
License MIT

All credit goes to @wessberg for making this happen!

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: preset-env labels Jun 25, 2019
@babel-bot
Copy link
Collaborator

babel-bot commented Jun 25, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11005/

@@ -6,7 +6,7 @@
"safari": "10.1",
"opera": "48",
"ios_saf": "10.3",
"and_chr": "71",
"and_ff": "64"
"and_chr": "74",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this technically a breaking change? A script which might have worked on and_chr 72 now it won't work anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our discussion, reverted this change and will push a new PR that updates the script to only update if it results in an earlier (or new) target

@existentialism existentialism merged commit cbb482e into master Jul 3, 2019
@existentialism existentialism deleted the issue-6605 branch July 3, 2019 14:37
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories PR: Dependency ⬆️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block scope transform not included when targeting Safari 10
4 participants