Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain typescript export-from-source #10167

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Retain typescript export-from-source #10167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/babel-plugin-transform-typescript/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ export default declare(
ExportNamedDeclaration(path) {
// remove export declaration if it's exporting only types
if (
!path.node.source &&
path.node.specifiers.length > 0 &&
!path.node.specifiers.find(exportSpecifier =>
path.scope.hasOwnBinding(exportSpecifier.local.name),
Expand All @@ -109,7 +110,10 @@ export default declare(

ExportSpecifier(path) {
// remove type exports
if (!path.scope.hasOwnBinding(path.node.local.name)) {
if (
!path.parent.source &&
!path.scope.hasOwnBinding(path.node.local.name)
) {
path.remove();
}
},
Expand Down
1 change: 1 addition & 0 deletions packages/babel-plugin-transform-typescript/test/fixtures/exports/default-literal/input.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export default "foo";
1 change: 1 addition & 0 deletions packages/babel-plugin-transform-typescript/test/fixtures/exports/default-literal/output.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export default "foo";
1 change: 1 addition & 0 deletions packages/babel-plugin-transform-typescript/test/fixtures/exports/export-from/input.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { bar } from './bar';
1 change: 1 addition & 0 deletions packages/babel-plugin-transform-typescript/test/fixtures/exports/export-from/output.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { bar } from './bar';