Added flow to babel cli #10219

letladi · 2019-07-14T18:47:35Z

added flow to the babel-cli package code.

nicolo-ribaudo · 2019-07-14T22:44:41Z

packages/babel-cli/src/babel-external-helpers.js

 import { buildExternalHelpers } from "@babel/core";

-function collect(value, previousValue): Array<string> {
+function collect(
+  value: String | any,


This isn't a string object, it's a string

Oh yes. Sorry, that is my mistake. Will fix

nicolo-ribaudo · 2019-07-14T22:44:55Z

packages/babel-cli/src/babel-external-helpers.js

  // If the user passed the option with no value, like "babel-external-helpers --whitelist", do nothing.
-  if (typeof value !== "string") return previousValue;
+  if (!isString(value)) return previousValue;


Why is this needed?

It isn't 🙈
Will fix.

babel-bot · 2019-07-15T05:18:16Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11155/

JLHwung · 2019-07-15T12:44:39Z

packages/babel-cli/src/babel/file.js

-      });
+        process.stdin.on("readable", function() {
+          const chunk = process.stdin.read();
+          if (isString(chunk)) code += toString(chunk);


We don't need isString and toString here.

Note that chunk could also be a Buffer (docs), so isString(chunk) is not equivalent to chunk !== null.

code += chunk will implicitly convert chunk to string since code is a string.

I can remove isString, but without toString flow will throw an error because it sees Buffer being incompatible with String

We can // $FlowIgnore it

JLHwung · 2019-07-15T12:59:00Z

packages/babel-cli/src/babel/file.js

@@ -184,15 +199,14 @@ export default async function({ cliOptions, babelOptions }) {
          }

          console.error(err);
-          return null;


I would suggest leave return null here so that we can make this PR focus on adding flow type annotation without changing any internal logic.

Note that you can use union type to specify this function returns either a Promise<Object> or null.

_filenames.map(async function(filename: string): Promise<Object> | null {

Good point. I'll make the fix.

…e possibility of chunk being a Buffer

nicolo-ribaudo · 2019-07-15T18:13:48Z

packages/babel-cli/src/babel/file.js

+  babelOptions,
+}: CmdOptions): Promise<void> {
+  function buildResult(fileResults: Array<Object>): CompilationOutput {
+    const map: Object = new sourceMap.SourceMapGenerator({


Doesn't flow already infer this type to the SourceMapGenerator class? (defined at

babel/lib/third-party-libs.js.flow

Line 147 in 7dc5fdb

declare class SourceMapGenerator {

)

It does, but the fromObject method expects a SourceMap but we pass it SourceMapGenerator and so causes errors, so maybe I should add SourceMap | SourceMapGenerator to that module declaration?

I'm thinking something like this fromObject(obj: SourceMap | SourceMapGenerator). This works without errors.

I think that fromObject(obj: SourceMap) was correct, and it isn't intended to be called with a SourceMapGenerator object.
It should be .fromObject(map.toJSON()).

Alright. I will make that change.

…ile list

… add-flow-to-babel-cli

JLHwung · 2019-07-18T23:02:36Z

@letladi Could you rebase your branch? Test fails because we have moved our fork of lerna into babel organization.

letladi · 2019-07-19T05:38:45Z

@JLHwung, will do.

* removed duplicate tests for @babel/highlight getChalk method * changed second 'getChalk' test case for when colors are not supported

* flow - allow type parameter defaults in function declarations * fix flow test * add intern_comments option * fix flow parser test * remove allowdefault from flowParseTypeParameterDeclaration * rename test cases

…e possibility of chunk being a Buffer

… add-flow-to-babel-cli

letladi · 2019-07-19T10:20:00Z

Sorry, I'm still working on the rebase (haven't done this before)

letladi · 2019-07-19T18:14:24Z

I'm closing this. I will send in a new pull request shortly.
The rebasing is showing me flames. 🤦🏽‍♂️

nicolo-ribaudo · 2019-07-19T18:16:33Z

I suggest squashing this commits before rebasing; it makes it easier to do.

letladi · 2019-07-19T19:03:09Z

I actually deleted everything. forked the repo again and added my changes; #10244

letladi added 5 commits July 13, 2019 22:38

added flow to directory cmd

d7714ad

added flow to file cmd

a0ec5e4

added flow to babel-cli utility file

a254447

corrected errors in babel-cli file command

af50714

added flow to babel-cli babel-external-helpers

a122deb

letladi changed the title ~~Add flow to babel cli~~ Added flow to babel cli Jul 14, 2019

nicolo-ribaudo reviewed Jul 14, 2019

View reviewed changes

added flow to babel-cli babel-external-helpers. Iteration #2

a16b3d4

JLHwung requested changes Jul 15, 2019

View reviewed changes

Letladi and others added 3 commits July 15, 2019 15:23

changed check inside readStdin inside babel file command to accomodat…

3d484d3

…e possibility of chunk being a Buffer

removed toString method inside readStdin of babel-cli file command

de384ff

fixed file command to only include flow changes

dbb53b4

nicolo-ribaudo reviewed Jul 15, 2019

View reviewed changes

nicolo-ribaudo added area: flow pkg: cli PR: Internal 🏠 A type of pull request used for our changelog categories labels Jul 15, 2019

letladi and others added 5 commits July 16, 2019 05:33

added SourceMapGenerator as an arg type to fromObject

2cd51e2

reverted to only using SourceMap inside fromObject method

3f759bc

went back to returning 'null' from the async function that compiles f…

d97a1f7

…ile list

Merge branch 'add-flow-to-babel-cli' of github.com:Letladi/babel into…

6667330

… add-flow-to-babel-cli

added null promise return type to method in file command

5e567d9

letladi and others added 6 commits July 19, 2019 10:33

Change duplicate tests for @babel/highlight getChalk method (#10093)

c67e611

* removed duplicate tests for @babel/highlight getChalk method * changed second 'getChalk' test case for when colors are not supported

flow - allow type parameter defaults in function declarations (#10084)

6d2f111

* flow - allow type parameter defaults in function declarations * fix flow test * add intern_comments option * fix flow parser test * remove allowdefault from flowParseTypeParameterDeclaration * rename test cases

added flow to directory cmd

a4889a4

added flow to file cmd

01e08c1

added flow to babel-cli utility file

f569385

corrected errors in babel-cli file command

3a680ac

letladi and others added 10 commits July 19, 2019 10:34

added flow to babel-cli babel-external-helpers

859bdaf

added flow to babel-cli babel-external-helpers. Iteration #2

ce1fc7b

changed check inside readStdin inside babel file command to accomodat…

ad6454d

…e possibility of chunk being a Buffer

removed toString method inside readStdin of babel-cli file command

daaae15

fixed file command to only include flow changes

588ec1a

added SourceMapGenerator as an arg type to fromObject

14859a3

reverted to only using SourceMap inside fromObject method

6de54cc

added null promise return type to method in file command

ce351a1

Merge branch 'add-flow-to-babel-cli' of github.com:Letladi/babel into…

e20ce35

… add-flow-to-babel-cli

changed walk file Promise call to only an object promise

3c31947

letladi closed this Jul 19, 2019

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 18, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added flow to babel cli #10219

Added flow to babel cli #10219

letladi commented Jul 14, 2019

nicolo-ribaudo Jul 14, 2019

letladi Jul 15, 2019

nicolo-ribaudo Jul 14, 2019

letladi Jul 15, 2019

babel-bot commented Jul 15, 2019 •

edited

JLHwung Jul 15, 2019

letladi Jul 15, 2019

nicolo-ribaudo Jul 15, 2019

letladi Jul 15, 2019

JLHwung Jul 15, 2019

letladi Jul 15, 2019

nicolo-ribaudo Jul 15, 2019

letladi Jul 15, 2019 •

edited

letladi Jul 15, 2019 •

edited

nicolo-ribaudo Jul 15, 2019

letladi Jul 16, 2019

JLHwung commented Jul 18, 2019 •

edited

letladi commented Jul 19, 2019

letladi commented Jul 19, 2019

letladi commented Jul 19, 2019

nicolo-ribaudo commented Jul 19, 2019

letladi commented Jul 19, 2019

Added flow to babel cli #10219

Added flow to babel cli #10219

Conversation

letladi commented Jul 14, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

babel-bot commented Jul 15, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

letladi Jul 15, 2019 • edited

Choose a reason for hiding this comment

letladi Jul 15, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JLHwung commented Jul 18, 2019 • edited

letladi commented Jul 19, 2019

letladi commented Jul 19, 2019

letladi commented Jul 19, 2019

nicolo-ribaudo commented Jul 19, 2019

letladi commented Jul 19, 2019

babel-bot commented Jul 15, 2019 •

edited

letladi Jul 15, 2019 •

edited

letladi Jul 15, 2019 •

edited

JLHwung commented Jul 18, 2019 •

edited