perf: always return void 0 as undefined node
#10243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
changed the title
void 0 as undefined codevoid 0 as undefined node
JLHwung
force-pushed
the
build-undefiend-without-scope
branch
from
74b5686
to
ca44286
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11182/ |
Maybe in the next major? |
nicolo-ribaudo
approved these changes
Jul 19, 2019
nicolo-ribaudo
added
the
PR: Performance 🏃♀️
Sure. We would not get rid of it on 7.x |
jridgewell
approved these changes
Jul 23, 2019
This was referenced Sep 15, 2019
This was referenced Oct 2, 2019
This was referenced Oct 5, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively,
this.hasBinding("undefined")will always returns true sinceundefinedis a global property. Asvoid 0is safer thanundefined, here we remove theifconditional check.buildUndefinedNodewill be a bit faster as it doesn't have to look through the nested scopes.I would also suggest that we move
buildUndefinedNodeto babel-types and clearly state that it is not relevant to the Scope class.