Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parenthesis for nullish coalescing #10269

Merged
merged 14 commits into from Sep 6, 2019
Merged

Fix parenthesis for nullish coalescing #10269

merged 14 commits into from Sep 6, 2019

Commits on Jul 24, 2019

  1. ♻️ added condition to check for left and right of nullish coalescing … 

    …operator and if any is a logical expression without a paren then throw an error
    @vivek12345
    vivek12345 committed Jul 24, 2019
    Copy the full SHA
    2ea36b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. 🐛 bugs fixed and test cases updated for babel parser

    @vivek12345
    vivek12345 committed Jul 25, 2019
    Copy the full SHA
    2ec028c View commit details
    Browse the repository at this point in the history

  2. ♻️ code comments added

    @vivek12345
    vivek12345 committed Jul 25, 2019
    Copy the full SHA
    82a6ac2 View commit details
    Browse the repository at this point in the history

  3. 🐛 spell error rectified

    @vivek12345
    vivek12345 committed Jul 25, 2019
    Copy the full SHA
    823d998 View commit details
    Browse the repository at this point in the history

  4. ♻️ failing test updated

    @vivek12345
    vivek12345 committed Jul 25, 2019
    Copy the full SHA
    a7037dd View commit details
    Browse the repository at this point in the history

  5. 🐛 push tests after make build

    @vivek12345
    vivek12345 committed Jul 25, 2019
    Copy the full SHA
    0fb1916 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2019

  1. Skip nullish-coalescing flow precedence tests 

    They're now incorrect
    @jridgewell
    jridgewell committed Jul 26, 2019
    Copy the full SHA
    3260bef View commit details
    Browse the repository at this point in the history

  2. ♻️ error message updated, binop priority of other logical operators +… 

    …1 from ?? and
    @vivek12345
    vivek12345 committed Jul 26, 2019
    Copy the full SHA
    6a0de8b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix-parenthesis-for-nullish-coalescing' of https://gith… 

    …ub.com/vivek12345/babel into fix-parenthesis-for-nullish-coalescing
    @vivek12345
    vivek12345 committed Jul 26, 2019
    Copy the full SHA
    5655417 View commit details
    Browse the repository at this point in the history

  4. ♻️ increaed the binOp for in and instanceOf, added logic to print the… 

    … brackets in an ?? && || expression, test cases added
    @vivek12345
    vivek12345 committed Jul 26, 2019
    Copy the full SHA
    d9ea03c View commit details
    Browse the repository at this point in the history

  5. 🐛 failing test fixed and comments updated

    @vivek12345
    vivek12345 committed Jul 26, 2019
    Copy the full SHA
    6918e86 View commit details
    Browse the repository at this point in the history

  6. ♻️ new lines added between tests

    @vivek12345
    vivek12345 committed Jul 26, 2019
    Copy the full SHA
    417cd40 View commit details
    Browse the repository at this point in the history

  7. ♻️ basic tests for checking the binOp of instanceOf, in and relationa… 

    …l operators to be equal added
    @vivek12345
    vivek12345 committed Jul 26, 2019
    Copy the full SHA
    4a2d372 View commit details
    Browse the repository at this point in the history

  8. ♻️ new lines added in between tests

    @vivek12345
    vivek12345 committed Jul 26, 2019
    Copy the full SHA
    40eb40e View commit details
    Browse the repository at this point in the history