Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix ESLint errors #10278

Merged
merged 1 commit into from Jul 29, 2019
Merged

chore: fix ESLint errors #10278

merged 1 commit into from Jul 29, 2019

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 29, 2019 •
edited

Q                       A
Fixed Issues? Master CI Linting fails
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? No
Documentation PR Link
Any Dependency Changes?
License MIT

A follow up to #10228. Lint errors come from merging #10244, which is not linting against ESLint 6.

xtuc
xtuc approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11260/

@existentialism existentialism merged commit f08062b into babel:master Jul 29, 2019
@JLHwung JLHwung deleted the fix-linting-error branch July 29, 2019 15:15
@commit-lint commit-lint bot mentioned this pull request Sep 27, 2019
Merged
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xtuc xtuc xtuc approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @babel-bot @xtuc @existentialism