Add parser support for static decorators #10388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: New Feature 🚀
nicolo-ribaudo
commented
Sep 3, 2019
| return this.state.pos + skip.length; | ||
| } | ||
|
|
||
| lookaheadCh(noNewLine?: boolean): number { |
There was a problem hiding this comment.
This does the same thing introduced by #10371 (when I initially wrote this code that PR didn't exist 😛)
I'll rebase this branch when that PR is merged, to use the method it introduces.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11445/ |
tim-mc
approved these changes
Sep 16, 2019
|
Just happened upon this PR. For the naming, how about just (I'm assuming that renaming |
|
The proposal has been rewritten |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a long time since the proposal update, the PR is here 😛
I'll close all the PRs for the older decorators versions. Note that they will still be maintianed with bug fixes and performance improvements if possible/needed.
Open question:
I created a new plugin (
staticDecorators) because we had two different plugins for the other decorators flavors (decoratorsanddecorators-legacy). If we can come up with a name for the proposal we had one year ago, I would prefer to use a single plugin live we did for the pipeline operator:(and leave
decorators-legacyfor backward compatibility)I'm cc-ing a few people which are/might be interested: @littledan @tomdale @kesne @tjcrowder @pabloalmunia