Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parser] Disallow static fields named constructor #10461

Merged
merged 3 commits into from Sep 17, 2019
Merged

[parser] Disallow static fields named constructor #10461

merged 3 commits into from Sep 17, 2019

Commits on Sep 17, 2019

  1. Disallow static fields named constructor in a class 

        - Disallowed static fields named `constructor` in a class (previously only non-static were disallowed)
    - Updated the text for the error for one consolidated warning, for both static and non-static fields
    - Added a test
    - Updated an existing test in the `flow` test suite of the parser to reflect the parse error.
  Strangely, the test used to pass and started failing when inlining the `isNonstaticConstructor` method, without any changes.
  In that test, `constructor` was a field, so in theory it should never have passed.
  Would appreciate some feedback on this, as I'm not 100% sure if this is somehow related to Flow
    @guywaldman
    guywaldman committed Sep 17, 2019
    Copy the full SHA
    693768f View commit details
    Browse the repository at this point in the history

  2. Update test262 whitelist

    @guywaldman
    guywaldman committed Sep 17, 2019
    Copy the full SHA
    09737cf View commit details
    Browse the repository at this point in the history

  3. Add comment and fix && operator

    @guywaldman
    guywaldman committed Sep 17, 2019
    Copy the full SHA
    ce70f7e View commit details
    Browse the repository at this point in the history