New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E test Babel with itself before publishing #10569
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
area: publishing process
area: tests
PR: Internal 🏠
A type of pull request used for our changelog categories
labels
Oct 16, 2019
nicolo-ribaudo
force-pushed
the
test-publish
branch
from
October 17, 2019 14:45
260352b
to
dd4a7d0
Compare
nicolo-ribaudo
force-pushed
the
test-publish
branch
5 times, most recently
from
October 17, 2019 19:29
29b1b8c
to
3ba482d
Compare
nicolo-ribaudo
force-pushed
the
test-publish
branch
4 times, most recently
from
October 17, 2019 19:50
fe0740a
to
4c39153
Compare
JLHwung
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the ci config and integration test scripts.
nicolo-ribaudo
force-pushed
the
test-publish
branch
from
November 11, 2019 22:05
68d0598
to
8f498d4
Compare
existentialism
approved these changes
Nov 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
lock
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Feb 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: publishing process
area: tests
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Internal 🏠
A type of pull request used for our changelog categories
Priority: High
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CircleCI workflow which
verdaccio
registry@babel/*
versions used by our repo, so that it uses the new "published" versionI created the workflow as two separate jobs so that if we decide to add other e2e tests (e.g.
create-react-app
,istanbul
, ...) we can run them in parallel after "publishing" Babel only once.I initially planned to only run these tests using a cronjob once a day, but since it only takes 7 minutes and it's run in parallel with all the other Travis/Circle tests, we could always run it.
This will probably need to change when we add other e2e tests.
The😄Introduce a bug
commit is an example of a bug which isn't caught by our unit tests but which fails the e2e test