Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E test Babel with itself before publishing #10569

Merged
merged 2 commits into from Nov 12, 2019

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Oct 16, 2019

Q                       A
Fixed Issues? Fixes #6134
Tests Added + Pass? Yes
License MIT

This PR adds a CircleCI workflow which

  1. Publishes Babel on an internal verdaccio registry
  2. Upgrades the @babel/* versions used by our repo, so that it uses the new "published" version
  3. Builds Babel and runs the tests

I created the workflow as two separate jobs so that if we decide to add other e2e tests (e.g. create-react-app, istanbul, ...) we can run them in parallel after "publishing" Babel only once.

I initially planned to only run these tests using a cronjob once a day, but since it only takes 7 minutes and it's run in parallel with all the other Travis/Circle tests, we could always run it.
This will probably need to change when we add other e2e tests.

The Introduce a bug commit is an example of a bug which isn't caught by our unit tests but which fails the e2e test 😄

@nicolo-ribaudo nicolo-ribaudo added area: publishing process area: tests PR: Internal 🏠 A type of pull request used for our changelog categories labels Oct 16, 2019
@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review October 17, 2019 15:07
@nicolo-ribaudo nicolo-ribaudo force-pushed the test-publish branch 5 times, most recently from 29b1b8c to 3ba482d Compare October 17, 2019 19:29
@buildsize
Copy link

buildsize bot commented Oct 17, 2019

File name Previous Size New Size Change
babel-preset-env.js 2.78 MB 2.78 MB 9 bytes (0%)
babel-preset-env.min.js 1.67 MB 1.67 MB 9 bytes (0%)
babel.js 2.96 MB 2.96 MB 9 bytes (0%)
babel.min.js 1.63 MB 1.63 MB 9 bytes (0%)
test262.tap 9.86 MB [deleted]

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the ci config and integration test scripts.

Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: publishing process area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories Priority: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infra: build/test master before publish
4 participants