Create File class for babel helpers #10575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
area: helpers
PR: Bug Fix 🐛
JLHwung
commented
Oct 18, 2019
packages/babel-helpers/src/index.js
Outdated
| const ast = t.file(helper.ast()); | ||
| return new File( | ||
| { | ||
| filename: `babel-helper://${name}`, |
There was a problem hiding this comment.
babel-helper:// is used to denote that this file is a babel helper snippet thus does not physically exist.
packages/babel-helpers/package.json
Outdated
| @@ -17,5 +17,8 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/helper-plugin-test-runner": "^7.0.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "@babel/core": "^7.0.0-0" | |||
There was a problem hiding this comment.
Adding (or updating) a peer dependency is a technically a breaking change. (semver/semver#502)
Maybe we could pass File as a parameter to loadHelper (from get and ensure), and only instantiate it if it is present?
There was a problem hiding this comment.
Good to know about that! Though I am not sure if, practically, there is anyone using @babel/helpers 7 with babel-core 6.
I end up revising helpers.ensure to accept extra fileClass because get interface is complicated enough.
nicolo-ribaudo
approved these changes
Nov 3, 2019
nicolo-ribaudo
force-pushed
the
finding-hub
branch
from
d7f76e3
to
e9111ff
Compare
* add test * fix: pass File to helper traverser * pass babel.File to helpers.ensure
nicolo-ribaudo
force-pushed
the
finding-hub
branch
from
e9111ff
to
2886e1e
Compare
This was referenced Mar 22, 2020
1 task
This was referenced Apr 11, 2020
This was referenced Apr 17, 2020
This was referenced Apr 24, 2020
This was referenced May 2, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we create a
Fileinstance for each helper snippets, by doing so we can ensure other visitors will have access to.hubwhen visiting the inserted nodes from helpers.