Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump @babel/* dev dependencies #10648

Merged
merged 4 commits into from Nov 12, 2019
Merged

bump @babel/* dev dependencies #10648

merged 4 commits into from Nov 12, 2019

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 5, 2019

Q                       A
Tests Added + Pass? Yes
Any Dependency Changes? Bump dev dependencies.
License MIT

Bump @babel/* devDependencies to 7.7.0, after that the yarn.lock is processed by yarn-deduplicate.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Nov 5, 2019
@existentialism
Copy link
Member

Do we need to bump the version value in our transform-runtime config?

@JLHwung
Copy link
Contributor Author

JLHwung commented Nov 5, 2019 •
edited

@existentialism Good point! I am shot by footgun.

Let's wait for the 7.7.2 release and I will update again afterwards.

Note: the size change comes from isIdentifierName introduced at 7.7.0 and interopRequireWildcard helper change.

@buildsize
Copy link

buildsize bot commented Nov 5, 2019 •
edited

File name Previous Size New Size Change
babel-preset-env.js 2.78 MB 2.78 MB 4.68 KB (0%)
babel-preset-env.min.js 1.67 MB 1.68 MB 3.22 KB (0%)
babel.js 2.96 MB 2.96 MB 5.91 KB (0%)
babel.min.js 1.63 MB 1.63 MB 4.1 KB (0%)
test262.tap 4.84 MB [deleted]

nicolo-ribaudo
nicolo-ribaudo approved these changes Nov 12, 2019
View reviewed changes
babel.config.js
? ["@babel/transform-runtime", { version: "7.4.4" }]
? [
"@babel/transform-runtime",
{ version: require("@babel/runtime/package").version },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this option is not effective until #10668 is merged, because we are always building against the lib version of @babel/*, which has inlined all the helper imports.

@nicolo-ribaudo nicolo-ribaudo merged commit ce070ce into babel:master Nov 12, 2019
This was referenced Dec 4, 2019
Merged
Open
Open
This was referenced Dec 12, 2019
Merged
Open
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Jan 20, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 5, 2020
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 12, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@existentialism existentialism Awaiting requested review from existentialism

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JLHwung @existentialism @nicolo-ribaudo