Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update asserts types #10689

Closed
wants to merge 1 commit into from
Closed

fix: update asserts types #10689

wants to merge 1 commit into from

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 9, 2019

Q                       A
Fixed Issues? Update asserts related type definitions
Patch: Bug Fix? Yes
License MIT

This is a byproduct of #10677. We align the asserts definition to the current behaviour (optional boolean) and remove asserts from visitors since it's not an AST Node.

@JLHwung JLHwung added the PR: Polish 💅 A type of pull request used for our changelog categories label Nov 9, 2019
@buildsize
Copy link

buildsize bot commented Nov 9, 2019

File name Previous Size New Size Change
babel-preset-env.js 2.78 MB 2.78 MB 56 bytes (0%)
babel-preset-env.min.js 1.67 MB 1.67 MB 51 bytes (0%)
babel.js 2.96 MB 2.96 MB 56 bytes (0%)
babel.min.js 1.63 MB 1.63 MB 51 bytes (0%)
test262.tap 4.91 MB [deleted]

@JLHwung
Copy link
Contributor Author

JLHwung commented Nov 9, 2019

Closing this PR as #10677 depends on it.

@JLHwung JLHwung closed this Nov 9, 2019
@JLHwung JLHwung deleted the update-asserts-types branch November 9, 2019 15:26
@JLHwung JLHwung removed the request for review from nicolo-ribaudo November 9, 2019 16:57
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JLHwung