Ignore PR job on master branch #10702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the docs I used to implement this: https://circleci.com/docs/2.0/configuration-reference/#filters-1 The only issue here is that there is not way for me to properly test this unless it's on master. |
I'll merge this PR since it's minimal; let's see if it works. |
JLHwung
approved these changes
Nov 13, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #10579. If we look at a commit which landed after, like 1d1101e, you can see that even though it's passing all checks the PR check is failing since the PR job is not approved to run.
This will incorrectly show all jobs as pending, which is noisy.
This PR aims at fixing this issue. Thanks to @nicolo-ribaudo for pointing it out!