Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing available plugins to babel-preset-env-standalone #10732

Merged
merged 2 commits into from Nov 18, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/babel-preset-env-standalone/package.json
Expand Up @@ -14,10 +14,13 @@
"devDependencies": {
"@babel/plugin-proposal-dynamic-import": "^7.7.0",
"@babel/plugin-proposal-json-strings": "^7.0.0",
"@babel/plugin-syntax-json-strings": "^7.2.0",
"@babel/plugin-syntax-top-level-await": "^7.7.0",
"@babel/plugin-transform-named-capturing-groups-regex": "^7.7.0",
"@babel/plugin-transform-new-target": "^7.4.4",
"@babel/preset-env": "^7.7.1",
"@babel/standalone": "^7.7.3"
"@babel/standalone": "^7.7.3",
"lodash": "^4.17.13"
},
"keywords": [
"babel",
Expand Down
2 changes: 2 additions & 0 deletions packages/babel-preset-env-standalone/src/available-plugins.js
Expand Up @@ -5,6 +5,8 @@ const notIncludedPlugins = {
"transform-new-target": require("@babel/plugin-transform-new-target"),
"proposal-json-strings": require("@babel/plugin-proposal-json-strings"),
"proposal-dynamic-import": require("@babel/plugin-proposal-dynamic-import"),
"syntax-json-strings": require("@babel/plugin-syntax-json-strings"),
"syntax-top-level-await": require("@babel/plugin-syntax-top-level-await"),
};

Object.keys(notIncludedPlugins).forEach(pluginName => {
Expand Down
14 changes: 14 additions & 0 deletions packages/babel-preset-env-standalone/test/available-plugins.js
@@ -0,0 +1,14 @@
import expectedAvailablePlugins from "@babel/preset-env/lib/available-plugins";
import actualAvailablePlugins from "../lib/available-plugins";
import difference from "lodash/difference";
describe("available-plugins", () => {
it("should be a superset of available-plugins in @babel/preset-env", () => {
const expectedPluginList = Object.keys(expectedAvailablePlugins);
expectedPluginList.sort();

const actualPluginList = Object.keys(actualAvailablePlugins);
actualPluginList.sort();
// If this test is failed, add the missing plugins to ./src/available-plugins
expect(difference(expectedPluginList, actualPluginList)).toEqual([]);
});
});