Tune eslint packages test configuration #10848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Internal 🏠
kaicataldo
approved these changes
Dec 9, 2019
nicolo-ribaudo
previously approved these changes
Dec 9, 2019
JLHwung
force-pushed
the
tune-eslint-test
branch
from
c401743
to
e9f6098
Compare
nicolo-ribaudo
dismissed
their stale review
The failing test is related to this PR
existentialism
approved these changes
Dec 9, 2019
|
@nicolo-ribaudo The test error is expected, because now I have added another test case when |
| @@ -18,26 +18,23 @@ function verifyAndAssertMessagesWithSpecificESLint( | |||
| node: true, | |||
| es6: true, | |||
| }, | |||
| ...overrideConfig, | |||
| parserOptions: { | |||
| sourceType, | |||
| ecmaFeatures: { | |||
| globalReturn: true, | |||
There was a problem hiding this comment.
Can we remove this? It's better to set it explicitly in the only test where we need it rather than having a default value.
nicolo-ribaudo
approved these changes
Dec 9, 2019
|
The Travis failures are caused by network errors |
This was referenced Feb 22, 2020
This was referenced Mar 7, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is extracted from a messy working branch on the upcoming Yarn 2 support: https://github.com/JLHwung/babel/commits/standalone-rollup-bundle
As a follow up to #10705 , the integration test should not read root babel configuration.