New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify runtime exports #10853
Specify runtime exports #10853
Changes from all commits
330352e
26d421c
96fc51e
1194ee6
485d48c
aababfc
60cc15a
92c8717
4997566
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
import _Array$from from "../../core-js/array/from"; | ||
import _isIterable from "../../core-js/is-iterable"; | ||
import _Symbol from "../../core-js/symbol"; | ||
import _Array$from from "@babel/runtime-corejs2/core-js/array/from"; | ||
import _isIterable from "@babel/runtime-corejs2/core-js/is-iterable"; | ||
import _Symbol from "@babel/runtime-corejs2/core-js/symbol"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For users using PnP, is it allowed for a package to import itself? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yarn PnP does not support esm yet: yarnpkg/berry#638 @merceyz Does PnP support There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that's totally fine |
||
export default function _iterableToArray(iter) { | ||
if (typeof _Symbol !== "undefined" && _isIterable(Object(iter))) return _Array$from(iter); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
import undef from "./temporalUndefined"; | ||
import err from "./tdz"; | ||
import undef from "@babel/runtime-corejs2/helpers/esm/temporalUndefined"; | ||
import err from "@babel/runtime-corejs2/helpers/esm/tdz"; | ||
export default function _temporalRef(val, name) { | ||
return val === undef ? err(name) : val; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
import arrayWithHoles from "./arrayWithHoles"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interesting, some corejs 2 helper files are tracked in git repository. Yet it is convenient so you can review the actual change of helper imports. /cc @rwjblue Will ember support self referencing package? In this case There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
That's exactly why we don't ignore some of these files 😛 |
||
import iterableToArray from "./iterableToArray"; | ||
import unsupportedIterableToArray from "./unsupportedIterableToArray"; | ||
import nonIterableRest from "./nonIterableRest"; | ||
import arrayWithHoles from "@babel/runtime-corejs2/helpers/esm/arrayWithHoles"; | ||
import iterableToArray from "@babel/runtime-corejs2/helpers/esm/iterableToArray"; | ||
import unsupportedIterableToArray from "@babel/runtime-corejs2/helpers/esm/unsupportedIterableToArray"; | ||
import nonIterableRest from "@babel/runtime-corejs2/helpers/esm/nonIterableRest"; | ||
export default function _toArray(arr) { | ||
return arrayWithHoles(arr) || iterableToArray(arr) || unsupportedIterableToArray(arr) || nonIterableRest(); | ||
} |
This comment was marked as outdated.
Sorry, something went wrong.