Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: specify github protocol #10872

Closed
wants to merge 2 commits into from

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 16, 2019

Q                       A
Fixed Issues? Yarn v2 will throw invalid file path kangax/compat-table on install
Any Dependency Changes?
License MIT

In this PR we specify the github: protocol for the compat-table dependencies. It is supported by both npm and yarn.

Note after merging this PR, installing compat-table on yarn 2 still fails due to yarnpkg/berry#637

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Dec 16, 2019
@JLHwung
Copy link
Contributor Author

JLHwung commented Dec 17, 2019

Closing this in favor of #10873.

@JLHwung JLHwung closed this Dec 17, 2019
@JLHwung JLHwung deleted the specify-github-protocol branch December 17, 2019 04:13
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant