fix: Object.getOwnPropertySymbols called on non-object #10902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
approved these changes
Dec 20, 2019
nicolo-ribaudo
added
PR: Bug Fix 🐛
JLHwung
reviewed
Dec 21, 2019
| @@ -399,7 +399,7 @@ helpers.objectSpread = helper("7.0.0-beta.0")` | |||
| var source = (arguments[i] != null) ? arguments[i] : {}; | |||
There was a problem hiding this comment.
I feel like we can add Object to arguments[i] and forget about Object(source) later.
There was a problem hiding this comment.
you mean like this?
var source = (arguments[i] != null) ? Object(arguments[i]) : {};
This was referenced Feb 22, 2020
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #10683
TypeError: Object.getOwnPropertySymbols called on non-objectoccurred in android default browser (android 4.x 5.x) when it uses the spread operator.Because this browser dose not support Object.getOwnPropertySymbols with non-object argument.