New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@babel-core: parse should parse only #10914
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
import { parse } from "@babel/parser"; | ||
import { codeFrameColumns } from "@babel/code-frame"; | ||
import generateMissingPluginMessage from "./util/missing-plugin-helper"; | ||
|
||
type AstRoot = BabelNodeFile | BabelNodeProgram; | ||
|
||
export type ParseResult = AstRoot; | ||
|
||
export default function parser( | ||
pluginPasses: PluginPasses, | ||
{ parserOpts, highlightCode = true, filename = "unknown" }: Object, | ||
code: string, | ||
): ParseResult { | ||
try { | ||
const results = []; | ||
for (const plugins of pluginPasses) { | ||
for (const plugin of plugins) { | ||
const { parserOverride } = plugin; | ||
if (parserOverride) { | ||
const ast = parserOverride(code, parserOpts, parse); | ||
|
||
if (ast !== undefined) results.push(ast); | ||
} | ||
} | ||
} | ||
|
||
if (results.length === 0) { | ||
return parse(code, parserOpts); | ||
} else if (results.length === 1) { | ||
if (typeof results[0].then === "function") { | ||
throw new Error( | ||
`You appear to be using an async parser plugin, ` + | ||
`which your current version of Babel does not support. ` + | ||
`If you're using a published plugin, you may need to upgrade ` + | ||
`your @babel/core version.`, | ||
); | ||
} | ||
return results[0]; | ||
} | ||
throw new Error("More than one plugin attempted to override parsing."); | ||
} catch (err) { | ||
if (err.code === "BABEL_PARSER_SOURCETYPE_MODULE_REQUIRED") { | ||
err.message += | ||
"\nConsider renaming the file to '.mjs', or setting sourceType:module " + | ||
"or sourceType:unambiguous in your Babel config for this file."; | ||
// err.code will be changed to BABEL_PARSE_ERROR later. | ||
} | ||
|
||
const { loc, missingPlugin } = err; | ||
if (loc) { | ||
const codeFrame = codeFrameColumns( | ||
code, | ||
{ | ||
start: { | ||
line: loc.line, | ||
column: loc.column + 1, | ||
}, | ||
}, | ||
{ | ||
highlightCode, | ||
}, | ||
); | ||
if (missingPlugin) { | ||
err.message = | ||
`${filename}: ` + | ||
generateMissingPluginMessage(missingPlugin[0], loc, codeFrame); | ||
} else { | ||
err.message = `${filename}: ${err.message}\n\n` + codeFrame; | ||
} | ||
err.code = "BABEL_PARSE_ERROR"; | ||
} | ||
throw err; | ||
} | ||
} |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Note for reviewers)
This wasn't already imported anywhere.