New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Promise.any requires global.AggregateError #10930
fix: Promise.any requires global.AggregateError #10930
Conversation
@@ -358,7 +363,7 @@ export const StaticProperties: ObjectMap<ObjectMap<string | string[]>> = { | |||
"esnext.promise.all-settled", | |||
...PromiseDependenciesWithIterators, | |||
], | |||
any: ["esnext.promise.any", ...PromiseDependenciesWithIterators], | |||
any: ["esnext.promise.any", ...PromiseAnyDependencies], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it would be better just add esnext.aggregate-error
to this line since at this moment it's used only here and I have no ideas wherePromiseAnyDependencies
can be used in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do. I thought it was some unwritten code convention that almost every entry is written as [name, ...depedencies]
.
C.f. zloirock/core-js#737 (comment)