Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added basic support for module attributes and tests updated #10962

Merged
merged 71 commits into from May 24, 2020
Merged

added basic support for module attributes and tests updated #10962

merged 71 commits into from May 24, 2020

Commits on Jan 5, 2020

  1. ♻️ added basic support for module attributes and tests updated

    Vivek Nayyar committed Jan 5, 2020
    Copy the full SHA
    7e1a783 View commit details
    Browse the repository at this point in the history

  2. attributes should be set only if moduleAttributes plugin is enabled, … 

    …refactored the parsing logic
    Vivek Nayyar committed Jan 5, 2020
    Copy the full SHA
    b810e31 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2020

  1. Merge branch 'master' of https://github.com/babel/babel into proposal… 

    …-module-attributes
    Vivek Nayyar committed Jan 25, 2020
    Copy the full SHA
    c35b06e View commit details
    Browse the repository at this point in the history

  2. ♻️ use new AST Node ImportAttribute for module attributes, tests upda… 

    …ted and only allow string literals for attribute values
    @vivek12345
    vivek12345 committed Jan 25, 2020
    Copy the full SHA
    4243ec1 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. Merge branch 'master' of https://github.com/babel/babel into proposal… 

    …-module-attributes
    @vivek12345
    vivek12345 committed Mar 11, 2020
    Copy the full SHA
    202af5a View commit details
    Browse the repository at this point in the history

  2. chore: fixed the eslint issue and sorted the errors in ascending order

    @vivek12345
    vivek12345 committed Mar 11, 2020
    Copy the full SHA
    14aae84 View commit details
    Browse the repository at this point in the history

  3. improvement: added support to throw error if duplicate attributes found

    @vivek12345
    vivek12345 committed Mar 11, 2020
    Copy the full SHA
    8c4ecf9 View commit details
    Browse the repository at this point in the history

  4. chore: fixed the failing test of babel plugin dotall regex

    @vivek12345
    vivek12345 committed Mar 11, 2020
    Copy the full SHA
    bbb6020 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. improvement: fixed error messages, confition to check presence of wit… 

    …h rectified and tests updated
    @vivek12345
    vivek12345 committed Mar 12, 2020
    Copy the full SHA
    ba5482e View commit details
    Browse the repository at this point in the history

  2. test: added a new test for allowing hasOwnProperty as one of the modu… 

    …le attributes
    @vivek12345
    vivek12345 committed Mar 12, 2020
    Copy the full SHA
    a038601 View commit details
    Browse the repository at this point in the history

  3. chore: added a mandatory version option to use along with module attr… 

    …ibutes plugin. tests updated
    @vivek12345
    vivek12345 committed Mar 12, 2020
    Copy the full SHA
    cde4f92 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. improvement: replaced object create with set and renamed test folder … 

    …to module-attributes
    @vivek12345
    vivek12345 committed Mar 13, 2020
    Copy the full SHA
    4f16179 View commit details
    Browse the repository at this point in the history

  2. Update packages/babel-parser/src/plugin-utils.js 

    improved error message on version mismatch

Co-Authored-By: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
    @vivek12345 @nicolo-ribaudo
    vivek12345 and nicolo-ribaudo committed Mar 13, 2020
    Copy the full SHA
    a264662 View commit details
    Browse the repository at this point in the history

  3. Update packages/babel-parser/src/parser/statement.js 

    comment rectified

Co-Authored-By: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
    @vivek12345 @nicolo-ribaudo
    vivek12345 and nicolo-ribaudo committed Mar 13, 2020
    Copy the full SHA
    c7c2c78 View commit details
    Browse the repository at this point in the history

  4. chore: unnecesaary comment removed and tests updated

    @vivek12345
    vivek12345 committed Mar 13, 2020
    Copy the full SHA
    2b5b437 View commit details
    Browse the repository at this point in the history

  5. improvement: using node.key.start instead of this.node.start to point… 

    … at the exact duplicate module attribute name
    @vivek12345
    vivek12345 committed Mar 13, 2020
    Copy the full SHA
    d36d314 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2020

  1. improvement: added check for line terminator

    @vivek12345
    vivek12345 committed Mar 14, 2020
    Copy the full SHA
    0a0958d View commit details
    Browse the repository at this point in the history

  2. chore: renamed valid-syntax-with-attributes-multiple-lines to invalid… 

    …-syntax-with-attributes-multiple-lines
    @vivek12345
    vivek12345 committed Mar 14, 2020
    Copy the full SHA
    f28f6ad View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2020

  1. improvement: changed the logic and tests to only support type as the … 

    …allowed module attribute
    @vivek12345
    vivek12345 committed Mar 15, 2020
    Copy the full SHA
    7806809 View commit details
    Browse the repository at this point in the history

  2. improvement: don't throw an error when attribute name is not type, ju… 

    …st raise it and continue parsing
    @vivek12345
    vivek12345 committed Mar 15, 2020
    Copy the full SHA
    a3c6a55 View commit details
    Browse the repository at this point in the history

  3. Revert output.js

    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 15, 2020
    Copy the full SHA
    65f9f5c View commit details
    Browse the repository at this point in the history

  4. improvement: removed the check for presence of tyep attribute as an e… 

    …arlier check will already catch this
    @vivek12345
    vivek12345 committed Mar 15, 2020
    Copy the full SHA
    1dacc99 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'proposal-module-attributes' of https://github.com/vivek… 

    …12345/babel into proposal-module-attributes
    @vivek12345
    vivek12345 committed Mar 15, 2020
    Copy the full SHA
    187d0d6 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' of https://github.com/babel/babel into proposal… 

    …-module-attributes
    @vivek12345
    vivek12345 committed Mar 15, 2020
    Copy the full SHA
    5cb50ed View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. feat: added syntax-import-module-attributes

    @vivek12345
    vivek12345 committed Mar 16, 2020
    Copy the full SHA
    40ddfab View commit details
    Browse the repository at this point in the history

  2. fix: fixed a message test in the readme for syntax-import-module-attr… 

    …ibutes
    @vivek12345
    vivek12345 committed Mar 16, 2020
    Copy the full SHA
    41bb994 View commit details
    Browse the repository at this point in the history

  3. refactor: removed the error key ModuleAttributesWithoutType as it is … 

    …not needed now
    @vivek12345
    vivek12345 committed Mar 16, 2020
    Copy the full SHA
    4030426 View commit details
    Browse the repository at this point in the history

  4. refactor: renamed syntax-import-module-attributes to syntax-module-at… 

    …tributes
    @vivek12345
    vivek12345 committed Mar 16, 2020
    Copy the full SHA
    792d096 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. ♻️ added basic support for module attributes and tests updated

    @nicolo-ribaudo
    Vivek Nayyar authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    a3c56ff View commit details
    Browse the repository at this point in the history

  2. attributes should be set only if moduleAttributes plugin is enabled, … 

    …refactored the parsing logic
    @nicolo-ribaudo
    Vivek Nayyar authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    cbcdb3d View commit details
    Browse the repository at this point in the history

  3. ♻️ use new AST Node ImportAttribute for module attributes, tests upda… 

    …ted and only allow string literals for attribute values
    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    e392984 View commit details
    Browse the repository at this point in the history

  4. chore: fixed the eslint issue and sorted the errors in ascending order

    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    256510b View commit details
    Browse the repository at this point in the history

  5. improvement: added support to throw error if duplicate attributes found

    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    1ee26a7 View commit details
    Browse the repository at this point in the history

  6. improvement: fixed error messages, confition to check presence of wit… 

    …h rectified and tests updated
    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    2a708a5 View commit details
    Browse the repository at this point in the history

  7. test: added a new test for allowing hasOwnProperty as one of the modu… 

    …le attributes
    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    f795d36 View commit details
    Browse the repository at this point in the history

  8. chore: added a mandatory version option to use along with module attr… 

    …ibutes plugin. tests updated
    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    35a85e9 View commit details
    Browse the repository at this point in the history

  9. improvement: replaced object create with set and renamed test folder … 

    …to module-attributes
    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    e3976f2 View commit details
    Browse the repository at this point in the history

  10. Update packages/babel-parser/src/plugin-utils.js 

    improved error message on version mismatch

Co-Authored-By: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
    @vivek12345 @nicolo-ribaudo
    vivek12345 and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    efacdaf View commit details
    Browse the repository at this point in the history

  11. Update packages/babel-parser/src/parser/statement.js 

    comment rectified

Co-Authored-By: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
    @vivek12345 @nicolo-ribaudo
    vivek12345 and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    4202fa9 View commit details
    Browse the repository at this point in the history

  12. chore: unnecesaary comment removed and tests updated

    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    e1016ad View commit details
    Browse the repository at this point in the history

  13. improvement: using node.key.start instead of this.node.start to point… 

    … at the exact duplicate module attribute name
    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    f89c15f View commit details
    Browse the repository at this point in the history

  14. improvement: added check for line terminator

    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    18dd064 View commit details
    Browse the repository at this point in the history

  15. chore: renamed valid-syntax-with-attributes-multiple-lines to invalid… 

    …-syntax-with-attributes-multiple-lines
    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    31f6a38 View commit details
    Browse the repository at this point in the history

  16. improvement: changed the logic and tests to only support type as the … 

    …allowed module attribute
    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    b98824f View commit details
    Browse the repository at this point in the history

  17. improvement: don't throw an error when attribute name is not type, ju… 

    …st raise it and continue parsing
    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    1c2be01 View commit details
    Browse the repository at this point in the history

  18. Revert output.js

    @nicolo-ribaudo
    nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    180b757 View commit details
    Browse the repository at this point in the history

  19. improvement: removed the check for presence of tyep attribute as an e… 

    …arlier check will already catch this
    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    ca2608f View commit details
    Browse the repository at this point in the history

  20. feat: added syntax-import-module-attributes

    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    3581a82 View commit details
    Browse the repository at this point in the history

  21. fix: fixed a message test in the readme for syntax-import-module-attr… 

    …ibutes
    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    b9d2939 View commit details
    Browse the repository at this point in the history

  22. refactor: removed the error key ModuleAttributesWithoutType as it is … 

    …not needed now
    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    24f7830 View commit details
    Browse the repository at this point in the history

  23. refactor: renamed syntax-import-module-attributes to syntax-module-at… 

    …tributes
    @vivek12345 @nicolo-ribaudo
    vivek12345 authored and nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    b1270c6 View commit details
    Browse the repository at this point in the history

  24. Format output files

    @nicolo-ribaudo
    nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    b7280e2 View commit details
    Browse the repository at this point in the history

  25. feb-2020 -> apr-2020

    @nicolo-ribaudo
    nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    6e4e730 View commit details
    Browse the repository at this point in the history

  26. Revert output.js

    @nicolo-ribaudo
    nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    7a2f4f8 View commit details
    Browse the repository at this point in the history

  27. Revert expression.js

    @nicolo-ribaudo
    nicolo-ribaudo committed Apr 28, 2020
    Copy the full SHA
    69f153e View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. relaxed the argument condition on dynamic imports from 1 to 2 for pro… 

    …posal module attributes
    @vivek12345
    vivek12345 committed Apr 30, 2020
    Copy the full SHA
    522bdc6 View commit details
    Browse the repository at this point in the history

  2. merged with upstream master

    @vivek12345
    vivek12345 committed Apr 30, 2020
    Copy the full SHA
    2a3e3d0 View commit details
    Browse the repository at this point in the history

  3. merged with remote changes and merge conflicts resolved

    @vivek12345
    vivek12345 committed Apr 30, 2020
    Copy the full SHA
    b1e7ddc View commit details
    Browse the repository at this point in the history

  4. bug: fixed the version to apr-2020

    @vivek12345
    vivek12345 committed Apr 30, 2020
    Copy the full SHA
    2e243af View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. polish: tune importArity error message

    @JLHwung
    JLHwung committed May 20, 2020
    Copy the full SHA
    f250937 View commit details
    Browse the repository at this point in the history

  2. fix: allow trailing comma in import()

    @JLHwung
    JLHwung committed May 20, 2020
    Copy the full SHA
    dbf36f6 View commit details
    Browse the repository at this point in the history

  3. chore: update version to latest month

    @JLHwung
    JLHwung committed May 20, 2020
    Copy the full SHA
    0ce6e62 View commit details
    Browse the repository at this point in the history

  4. add moduleAttributes to parse typings

    @JLHwung
    JLHwung committed May 20, 2020
    Copy the full SHA
    9f80885 View commit details
    Browse the repository at this point in the history

  5. feat: add syntax-module-attributes to babel-standalone

    @JLHwung
    JLHwung committed May 20, 2020
    Copy the full SHA
    aa22f1a View commit details
    Browse the repository at this point in the history

  6. fix: forbid spread element in second argument of import()

    @JLHwung
    JLHwung committed May 20, 2020
    Copy the full SHA
    967a9be View commit details
    Browse the repository at this point in the history

  7. expect moduleAttributes when there are two arguments of import()

    @JLHwung
    JLHwung committed May 20, 2020
    Copy the full SHA
    d06d08b View commit details
    Browse the repository at this point in the history

  8. refactor: minor tweaks

    @JLHwung
    JLHwung committed May 20, 2020
    Copy the full SHA
    f051fa1 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'upstream/master' into proposal-module-a… 

    …ttributes
    @JLHwung
    JLHwung committed May 20, 2020
    Copy the full SHA
    01933e4 View commit details
    Browse the repository at this point in the history

  10. chore: rearrange tests

    @JLHwung
    JLHwung committed May 20, 2020
    Copy the full SHA
    dde6294 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. Update packages/babel-parser/src/parser/expression.js 

    Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
    @JLHwung @nicolo-ribaudo
    JLHwung and nicolo-ribaudo committed May 21, 2020
    Copy the full SHA
    907aacd View commit details
    Browse the repository at this point in the history

Commits on May 24, 2020

  1. Merge remote-tracking branch 'upstream/master' into proposal-module-a… 

    …ttributes
    @nicolo-ribaudo
    nicolo-ribaudo committed May 24, 2020
    Copy the full SHA
    63b7c44 View commit details
    Browse the repository at this point in the history