Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polish: throw human-friendly error when item-option pair is incorrectly unwrapped #10969

Merged
merged 12 commits into from Jan 20, 2020
Merged

polish: throw human-friendly error when item-option pair is incorrectly unwrapped #10969

merged 12 commits into from Jan 20, 2020

Commits on Jan 17, 2020

  1. polish: throw human-friendly error when item-option pair is incorrect… 

    …ly unwrapped
    @JLHwung
    JLHwung committed Jan 17, 2020
    Copy the full SHA
    0e1858b View commit details
    Browse the repository at this point in the history

  2. add testcase for plugin

    @JLHwung
    JLHwung committed Jan 17, 2020
    Copy the full SHA
    12da11a View commit details
    Browse the repository at this point in the history

  3. fix: exclude false positive

    @JLHwung
    JLHwung committed Jan 17, 2020
    Copy the full SHA
    fbc1912 View commit details
    Browse the repository at this point in the history

  4. fix: validate should support plugin optionsSourceKind

    @JLHwung
    JLHwung committed Jan 17, 2020
    Copy the full SHA
    c5ccdd5 View commit details
    Browse the repository at this point in the history

  5. Revert "fix: validate should support plugin optionsSourceKind" 

    This reverts commit 60dde89.
    @JLHwung
    JLHwung committed Jan 17, 2020
    Copy the full SHA
    be7a725 View commit details
    Browse the repository at this point in the history

  6. fix: validate plugin object in assertNoUnwrappedItemOptionPairs

    @JLHwung
    JLHwung committed Jan 17, 2020
    Copy the full SHA
    86a09d5 View commit details
    Browse the repository at this point in the history

  7. fix flow error

    @JLHwung
    JLHwung committed Jan 17, 2020
    Copy the full SHA
    0fcbd09 View commit details
    Browse the repository at this point in the history

  8. update test fixtures

    @JLHwung
    JLHwung committed Jan 17, 2020
    Copy the full SHA
    5595936 View commit details
    Browse the repository at this point in the history

  9. refactor: move to loadDescriptor catch clause

    @JLHwung
    JLHwung committed Jan 17, 2020
    Copy the full SHA
    7f4c8a0 View commit details
    Browse the repository at this point in the history

  10. chore: throw Error instead of builtin ReferenceError

    @JLHwung
    JLHwung committed Jan 17, 2020
    Copy the full SHA
    60a9b38 View commit details
    Browse the repository at this point in the history

  11. fix flow errors

    @JLHwung
    JLHwung committed Jan 17, 2020
    Copy the full SHA
    021c8ea View commit details
    Browse the repository at this point in the history

  12. chore: add more test cases

    @JLHwung
    JLHwung committed Jan 17, 2020
    Copy the full SHA
    5a24975 View commit details
    Browse the repository at this point in the history