Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numeric separator to shippedProposals #10971

Merged
merged 8 commits into from Mar 16, 2020
Merged

Add numeric separator to shippedProposals #10971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
750faf4
add plugins
Wetinee Jan 9, 2020
c349a20
add plugin description
Wetinee Jan 9, 2020
795da26
run build-data
Wetinee Jan 9, 2020
364dbf9
set shipped proposals true
Wetinee Jan 9, 2020
4439aa4
update test fixtures
Wetinee Feb 22, 2020
a35bf38
corejs.proposals should not imply shipped proposals
Wetinee Feb 22, 2020
5564cb8
fix eslint errors
Wetinee Feb 23, 2020
11d2efd
create new object in packages/babel-compat-data/scripts/data/plugin-f…
Wetinee Feb 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/babel-compat-data/data/plugins.json
View file
Open in desktop
Expand Up @@ -328,6 +328,14 @@
"opera": "37",
"electron": "1.1"
},
"proposal-numeric-separator": {
"chrome": "75",
"firefox": "70",
"safari": "13",
"node": "12.5",
"ios": "13",
"opera": "62"
},
"transform-member-expression-literals": {
"chrome": "7",
"opera": "12",
Expand Down
5 changes: 5 additions & 0 deletions packages/babel-compat-data/scripts/data/plugin-features.js
View file
Open in desktop
Expand Up @@ -116,9 +116,14 @@ const es2020 = {
"proposal-optional-chaining": "optional chaining operator (?.)",
};

const shippedProposal = {
"proposal-numeric-separator": "numeric separator",
};

// Run plugins for modern features first
module.exports = Object.assign(
{},
shippedProposal,
es2020,
es2019,
es2018,
Expand Down
5 changes: 4 additions & 1 deletion packages/babel-preset-env/data/shipped-proposals.js
View file
Open in desktop
Expand Up @@ -2,13 +2,16 @@
// These mappings represent the syntax proposals that have been
// shipped by browsers, and are enabled by the `shippedProposals` option.

const proposalPlugins = {};
const proposalPlugins = {
"proposal-numeric-separator": true
};

// use intermediary object to enforce alphabetical key order
const pluginSyntaxObject = {
"proposal-async-generator-functions": "syntax-async-generators",
"proposal-json-strings": "syntax-json-strings",
"proposal-nullish-coalescing-operator": "syntax-nullish-coalescing-operator",
"proposal-numeric-separator": "syntax-numeric-separator",
"proposal-object-rest-spread": "syntax-object-rest-spread",
"proposal-optional-catch-binding": "syntax-optional-catch-binding",
"proposal-optional-chaining": "syntax-optional-chaining",
Expand Down
2 changes: 2 additions & 0 deletions packages/babel-preset-env/package.json
View file
Open in desktop
Expand Up @@ -19,6 +19,7 @@
"@babel/plugin-proposal-dynamic-import": "^7.8.3",
"@babel/plugin-proposal-json-strings": "^7.8.3",
"@babel/plugin-proposal-nullish-coalescing-operator": "^7.8.3",
"@babel/plugin-proposal-numeric-separator": "^7.8.3",
"@babel/plugin-proposal-object-rest-spread": "^7.8.3",
"@babel/plugin-proposal-optional-catch-binding": "^7.8.3",
"@babel/plugin-proposal-optional-chaining": "^7.8.3",
Expand All @@ -27,6 +28,7 @@
"@babel/plugin-syntax-dynamic-import": "^7.8.0",
"@babel/plugin-syntax-json-strings": "^7.8.0",
"@babel/plugin-syntax-nullish-coalescing-operator": "^7.8.0",
"@babel/plugin-syntax-numeric-separator": "^7.8.0",
"@babel/plugin-syntax-object-rest-spread": "^7.8.0",
"@babel/plugin-syntax-optional-catch-binding": "^7.8.0",
"@babel/plugin-syntax-optional-chaining": "^7.8.0",
Expand Down
4 changes: 4 additions & 0 deletions packages/babel-preset-env/src/available-plugins.js
View file
Open in desktop
Expand Up @@ -5,6 +5,7 @@ import syntaxAsyncGenerators from "@babel/plugin-syntax-async-generators";
import syntaxDynamicImport from "@babel/plugin-syntax-dynamic-import";
import syntaxJsonStrings from "@babel/plugin-syntax-json-strings";
import syntaxNullishCoalescingOperator from "@babel/plugin-syntax-nullish-coalescing-operator";
import syntaxNumericSeparator from "@babel/plugin-syntax-numeric-separator";
import syntaxObjectRestSpread from "@babel/plugin-syntax-object-rest-spread";
import syntaxOptionalCatchBinding from "@babel/plugin-syntax-optional-catch-binding";
import syntaxOptionalChaining from "@babel/plugin-syntax-optional-chaining";
Expand All @@ -13,6 +14,7 @@ import proposalAsyncGeneratorFunctions from "@babel/plugin-proposal-async-genera
import proposalDynamicImport from "@babel/plugin-proposal-dynamic-import";
import proposalJsonStrings from "@babel/plugin-proposal-json-strings";
import proposalNullishCoalescingOperator from "@babel/plugin-proposal-nullish-coalescing-operator";
import proposalNumericSeparator from "@babel/plugin-proposal-numeric-separator";
import proposalObjectRestSpread from "@babel/plugin-proposal-object-rest-spread";
import proposalOptionalCatchBinding from "@babel/plugin-proposal-optional-catch-binding";
import proposalOptionalChaining from "@babel/plugin-proposal-optional-chaining";
Expand Down Expand Up @@ -54,6 +56,7 @@ export default {
"proposal-dynamic-import": proposalDynamicImport,
"proposal-json-strings": proposalJsonStrings,
"proposal-nullish-coalescing-operator": proposalNullishCoalescingOperator,
"proposal-numeric-separator": proposalNumericSeparator,
"proposal-object-rest-spread": proposalObjectRestSpread,
"proposal-optional-catch-binding": proposalOptionalCatchBinding,
"proposal-optional-chaining": proposalOptionalChaining,
Expand All @@ -62,6 +65,7 @@ export default {
"syntax-dynamic-import": syntaxDynamicImport,
"syntax-json-strings": syntaxJsonStrings,
"syntax-nullish-coalescing-operator": syntaxNullishCoalescingOperator,
"syntax-numeric-separator": syntaxNumericSeparator,
"syntax-object-rest-spread": syntaxObjectRestSpread,
"syntax-optional-catch-binding": syntaxOptionalCatchBinding,
"syntax-optional-chaining": syntaxOptionalChaining,
Expand Down
11 changes: 5 additions & 6 deletions packages/babel-preset-env/src/normalize-options.js
View file
Open in desktop
Expand Up @@ -267,12 +267,11 @@ export default function normalizeOptions(opts: Options) {

checkDuplicateIncludeExcludes(include, exclude);

const shippedProposals =
validateBoolOption(
TopLevelOptions.shippedProposals,
opts.shippedProposals,
false,
) || corejs.proposals;
const shippedProposals = validateBoolOption(
TopLevelOptions.shippedProposals,
opts.shippedProposals,
false,
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a breaking change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Practically it is not a breaking change, because we have never added any plugins to shippedProposals. So even if corejs.proposals implies shippedProposals, our user can not observe the effect. I would consider this change as bugfix.


return {
configPath: validateConfigPathOption(opts.configPath),
Expand Down
1 change: 1 addition & 0 deletions .../babel-preset-env/test/fixtures/debug/entry-corejs2-shippedProposals-chrome-71/stdout.txt
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ Using plugins:
syntax-optional-catch-binding { "chrome":"71" }
syntax-async-generators { "chrome":"71" }
syntax-object-rest-spread { "chrome":"71" }
proposal-numeric-separator { "chrome":"71" }
transform-modules-commonjs { "chrome":"71" }
proposal-dynamic-import { "chrome":"71" }

Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs2-shippedProposals/stdout.txt
View file
Open in desktop
Expand Up @@ -37,6 +37,7 @@ Using plugins:
transform-typeof-symbol {}
transform-new-target {}
transform-regenerator {}
proposal-numeric-separator {}
transform-member-expression-literals {}
transform-property-literals {}
transform-reserved-words {}
Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs3-all-chrome-71/stdout.txt
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ Using plugins:
syntax-optional-catch-binding { "chrome":"71" }
syntax-async-generators { "chrome":"71" }
syntax-object-rest-spread { "chrome":"71" }
proposal-numeric-separator { "chrome":"71" }
transform-modules-commonjs { "chrome":"71" }
proposal-dynamic-import { "chrome":"71" }

Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs3-all/stdout.txt
View file
Open in desktop
Expand Up @@ -37,6 +37,7 @@ Using plugins:
transform-typeof-symbol {}
transform-new-target {}
transform-regenerator {}
proposal-numeric-separator {}
transform-member-expression-literals {}
transform-property-literals {}
transform-reserved-words {}
Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs3-babel-polyfill/stdout.txt
View file
Open in desktop
Expand Up @@ -37,6 +37,7 @@ Using plugins:
transform-typeof-symbol {}
transform-new-target {}
transform-regenerator {}
proposal-numeric-separator {}
transform-member-expression-literals {}
transform-property-literals {}
transform-reserved-words {}
Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs3-es-chrome-71/stdout.txt
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ Using plugins:
syntax-optional-catch-binding { "chrome":"71" }
syntax-async-generators { "chrome":"71" }
syntax-object-rest-spread { "chrome":"71" }
proposal-numeric-separator { "chrome":"71" }
transform-modules-commonjs { "chrome":"71" }
proposal-dynamic-import { "chrome":"71" }

Expand Down
1 change: 1 addition & 0 deletions ...ages/babel-preset-env/test/fixtures/debug/entry-corejs3-es-proposals-chrome-71/stdout.txt
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ Using plugins:
syntax-optional-catch-binding { "chrome":"71" }
syntax-async-generators { "chrome":"71" }
syntax-object-rest-spread { "chrome":"71" }
proposal-numeric-separator { "chrome":"71" }
transform-modules-commonjs { "chrome":"71" }
proposal-dynamic-import { "chrome":"71" }

Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs3-es-proposals/stdout.txt
View file
Open in desktop
Expand Up @@ -37,6 +37,7 @@ Using plugins:
transform-typeof-symbol {}
transform-new-target {}
transform-regenerator {}
proposal-numeric-separator {}
transform-member-expression-literals {}
transform-property-literals {}
transform-reserved-words {}
Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs3-es/stdout.txt
View file
Open in desktop
Expand Up @@ -37,6 +37,7 @@ Using plugins:
transform-typeof-symbol {}
transform-new-target {}
transform-regenerator {}
proposal-numeric-separator {}
transform-member-expression-literals {}
transform-property-literals {}
transform-reserved-words {}
Expand Down
1 change: 1 addition & 0 deletions ...ages/babel-preset-env/test/fixtures/debug/entry-corejs3-runtime-only-chrome-71/stdout.txt
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ Using plugins:
syntax-optional-catch-binding { "chrome":"71" }
syntax-async-generators { "chrome":"71" }
syntax-object-rest-spread { "chrome":"71" }
proposal-numeric-separator { "chrome":"71" }
transform-modules-commonjs { "chrome":"71" }
proposal-dynamic-import { "chrome":"71" }

Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs3-runtime-only/stdout.txt
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ Using plugins:
syntax-optional-catch-binding { "chrome":"71" }
syntax-async-generators { "chrome":"71" }
syntax-object-rest-spread { "chrome":"71" }
proposal-numeric-separator { "chrome":"71" }
transform-modules-commonjs { "chrome":"71" }
proposal-dynamic-import { "chrome":"71" }

Expand Down
1 change: 1 addition & 0 deletions .../babel-preset-env/test/fixtures/debug/entry-corejs3-specific-entries-chrome-71/stdout.txt
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ Using plugins:
syntax-optional-catch-binding { "chrome":"71" }
syntax-async-generators { "chrome":"71" }
syntax-object-rest-spread { "chrome":"71" }
proposal-numeric-separator { "chrome":"71" }
transform-modules-commonjs { "chrome":"71" }
proposal-dynamic-import { "chrome":"71" }

Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs3-specific-entries/stdout.txt
View file
Open in desktop
Expand Up @@ -37,6 +37,7 @@ Using plugins:
transform-typeof-symbol {}
transform-new-target {}
transform-regenerator {}
proposal-numeric-separator {}
transform-member-expression-literals {}
transform-property-literals {}
transform-reserved-words {}
Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs3-stable-chrome-71/stdout.txt
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ Using plugins:
syntax-optional-catch-binding { "chrome":"71" }
syntax-async-generators { "chrome":"71" }
syntax-object-rest-spread { "chrome":"71" }
proposal-numeric-separator { "chrome":"71" }
transform-modules-commonjs { "chrome":"71" }
proposal-dynamic-import { "chrome":"71" }

Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs3-stable-samsung-8.2/stdout.txt
View file
Open in desktop
Expand Up @@ -16,6 +16,7 @@ Using plugins:
syntax-object-rest-spread { "samsung":"8.2" }
proposal-unicode-property-regex { "samsung":"8.2" }
transform-named-capturing-groups-regex { "samsung":"8.2" }
proposal-numeric-separator { "samsung":"8.2" }
transform-modules-commonjs { "samsung":"8.2" }
proposal-dynamic-import { "samsung":"8.2" }

Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs3-stable/stdout.txt
View file
Open in desktop
Expand Up @@ -37,6 +37,7 @@ Using plugins:
transform-typeof-symbol {}
transform-new-target {}
transform-regenerator {}
proposal-numeric-separator {}
transform-member-expression-literals {}
transform-property-literals {}
transform-reserved-words {}
Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs3-stage-chrome-71/stdout.txt
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ Using plugins:
syntax-optional-catch-binding { "chrome":"71" }
syntax-async-generators { "chrome":"71" }
syntax-object-rest-spread { "chrome":"71" }
proposal-numeric-separator { "chrome":"71" }
transform-modules-commonjs { "chrome":"71" }
proposal-dynamic-import { "chrome":"71" }

Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs3-stage/stdout.txt
View file
Open in desktop
Expand Up @@ -37,6 +37,7 @@ Using plugins:
transform-typeof-symbol {}
transform-new-target {}
transform-regenerator {}
proposal-numeric-separator {}
transform-member-expression-literals {}
transform-property-literals {}
transform-reserved-words {}
Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs3-web-chrome-71/stdout.txt
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ Using plugins:
syntax-optional-catch-binding { "chrome":"71" }
syntax-async-generators { "chrome":"71" }
syntax-object-rest-spread { "chrome":"71" }
proposal-numeric-separator { "chrome":"71" }
transform-modules-commonjs { "chrome":"71" }
proposal-dynamic-import { "chrome":"71" }

Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-corejs3-web/stdout.txt
View file
Open in desktop
Expand Up @@ -37,6 +37,7 @@ Using plugins:
transform-typeof-symbol {}
transform-new-target {}
transform-regenerator {}
proposal-numeric-separator {}
transform-member-expression-literals {}
transform-property-literals {}
transform-reserved-words {}
Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/entry-no-corejs-shippedProposals/stdout.txt
View file
Open in desktop
Expand Up @@ -37,6 +37,7 @@ Using plugins:
transform-typeof-symbol {}
transform-new-target {}
transform-regenerator {}
proposal-numeric-separator {}
transform-member-expression-literals {}
transform-property-literals {}
transform-reserved-words {}
Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/usage-corejs2-shippedProposals-1/stdout.txt
View file
Open in desktop
Expand Up @@ -40,6 +40,7 @@ Using plugins:
transform-typeof-symbol { "ie":"11" }
transform-new-target { "ie":"11" }
transform-regenerator { "firefox":"50", "ie":"11" }
proposal-numeric-separator { "chrome":"52", "firefox":"50", "ie":"11" }
transform-modules-commonjs { "chrome":"52", "firefox":"50", "ie":"11" }
proposal-dynamic-import { "chrome":"52", "firefox":"50", "ie":"11" }

Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/usage-corejs2-shippedProposals-2/stdout.txt
View file
Open in desktop
Expand Up @@ -40,6 +40,7 @@ Using plugins:
transform-typeof-symbol { "ie":"11" }
transform-new-target { "ie":"11" }
transform-regenerator { "firefox":"50", "ie":"11" }
proposal-numeric-separator { "chrome":"52", "firefox":"50", "ie":"11" }
transform-modules-commonjs { "chrome":"52", "firefox":"50", "ie":"11" }
proposal-dynamic-import { "chrome":"52", "firefox":"50", "ie":"11" }

Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/usage-corejs3-shippedProposals-1/stdout.txt
View file
Open in desktop
Expand Up @@ -40,6 +40,7 @@ Using plugins:
transform-typeof-symbol { "ie":"11" }
transform-new-target { "ie":"11" }
transform-regenerator { "firefox":"50", "ie":"11" }
proposal-numeric-separator { "chrome":"52", "firefox":"50", "ie":"11" }
transform-modules-commonjs { "chrome":"52", "firefox":"50", "ie":"11" }
proposal-dynamic-import { "chrome":"52", "firefox":"50", "ie":"11" }

Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/test/fixtures/debug/usage-corejs3-shippedProposals-2/stdout.txt
View file
Open in desktop
Expand Up @@ -40,6 +40,7 @@ Using plugins:
transform-typeof-symbol { "ie":"11" }
transform-new-target { "ie":"11" }
transform-regenerator { "firefox":"50", "ie":"11" }
proposal-numeric-separator { "chrome":"52", "firefox":"50", "ie":"11" }
transform-modules-commonjs { "chrome":"52", "firefox":"50", "ie":"11" }
proposal-dynamic-import { "chrome":"52", "firefox":"50", "ie":"11" }

Expand Down