New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added instructions to fork the repo in order to setup. #10973
Added instructions to fork the repo in order to setup. #10973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
|
CONTRIBUTING.md
Outdated
@@ -49,8 +48,12 @@ Installation instructions can be found here: https://yarnpkg.com/en/docs/install | |||
|
|||
### Setup | |||
|
|||
Fork the `babel` repository to your Github Account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fork the `babel` repository to your Github Account. | |
Fork the `babel` repository to your GitHub Account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, making the changes as soon as I get how to undo the formatting. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than suggestions above, LGTM. Thanks for doing this!
CONTRIBUTING.md
Outdated
- Check out [`/doc`](https://github.com/babel/babel/tree/master/doc) for information about Babel's internals | ||
- Check out [the Babel Plugin Handbook](https://github.com/thejameskyle/babel-handbook/blob/master/translations/en/plugin-handbook.md#babel-plugin-handbook) - core plugins are written the same way as any other plugin! | ||
- Check out [AST Explorer](http://astexplorer.net/#/scUfOmVOG5) to learn more about ASTs or make your own plugin in the browser | ||
- [ASTs](https://en.wikipedia.org/wiki/Abstract_syntax_tree) (Abstract Syntax Tree): The Babel AST [spec](https://github.com/babel/babel/blob/master/packages/babel-parser/ast/spec.md) is a bit different from [ESTree](https://github.com/estree/estree). The differences are listed [here](https://babeljs.io/docs/en/next/babel-parser.html#output). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines should be kept indented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolo-ribaudo These changes were automatically made by the Markdown Formatter in my VSCode. Can you please guide me how to undo them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolo-ribaudo Tried making changes and committed it but the formatter wrongly indented the starting HTML code. Which formatter should I use? Please help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can temporarily disable the formatter extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, please review the changes made. Have made a new commit. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, thanks! I didn't realize that there was only one space instead of 2 😅
Your formatter was actually right and was showing that the old file has an indentation bug.
1961b90
to
31032e2
Compare
While setting up the repository, most beginners may not fork the repository and directly clone the upstream as mentioned here - https://github.com/babel/babel/blob/master/CONTRIBUTING.md#setup
Thus, added an instruction to fork the repository to their Github Account before cloning it and instead clone their forked repository. PTAL if this is feasible.
Thanks. 🎉