Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive @babel/preset-env-standalone #10993

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jan 12, 2020

Q                       A
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This package shouldn't be used anymore after #10821.

⚠️ This PR shouldn't be merged until the REPL supports not loading @babel/preset-env-standalone from CircleCI artifacts.


Depends on babel/website#2157 The REPL has problems even without merging this PR.

@nicolo-ribaudo nicolo-ribaudo added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: standalone pkg: preset-env labels Jan 12, 2020
@nicolo-ribaudo nicolo-ribaudo changed the title Archive babel preset env standalone Archive @babel/preset-env-standalone Jan 12, 2020
@JLHwung
Copy link
Contributor

JLHwung commented Jan 13, 2020

until the REPL supports not loading @babel/preset-env-standalone from CircleCI artifacts.

Note that REPL still needs to load preset-env-standalone for older versions than 7.8.0. I suggest we preserve its backward compatibility to 7.0.0 until, I don't know, maybe 2021.

@nicolo-ribaudo
Copy link
Member Author

Yes, but I think that we should check the version. If <7.8.0 then load the second file, otherwise don't.

@nicolo-ribaudo nicolo-ribaudo force-pushed the archive-babel-preset-env-standalone branch from a6f9eaf to 86a6a9c Compare January 13, 2020 01:20
@nicolo-ribaudo nicolo-ribaudo force-pushed the archive-babel-preset-env-standalone branch from 7781620 to 934f51f Compare February 1, 2020 00:31
@nicolo-ribaudo nicolo-ribaudo force-pushed the archive-babel-preset-env-standalone branch from 934f51f to 6419d59 Compare February 1, 2020 00:33
It's already in babel-standalone/test/babel.js
@nicolo-ribaudo nicolo-ribaudo merged commit 755ec19 into babel:master Feb 6, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the archive-babel-preset-env-standalone branch February 6, 2020 00:03
rajasekarm pushed a commit to rajasekarm/babel that referenced this pull request Feb 17, 2020
* Move @babel/preset-env-standalone to babel-archive

babel/babel-archive@a1fadd2

* Move tests to @babel/standalone

* Remove references in build scripts

* Update lockfile

* Delete duplicated test file.

It's already in babel-standalone/test/babel.js
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 7, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env pkg: standalone PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants