New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable no-process-exit
#11025
Enable no-process-exit
#11025
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,7 +92,7 @@ getV8Flags(function(err, v8Flags) { | |
if (signal) { | ||
process.kill(process.pid, signal); | ||
} else { | ||
process.exit(code); | ||
process.exitCode = code; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. node.js will terminate when all |
||
} | ||
}); | ||
}); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,10 +7,9 @@ var fs = require("fs"); | |
var filename = process.argv[2]; | ||
if (!filename) { | ||
console.error("no filename specified"); | ||
process.exit(0); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
} | ||
|
||
var file = fs.readFileSync(filename, "utf8"); | ||
var ast = parser.parse(file); | ||
} else { | ||
var file = fs.readFileSync(filename, "utf8"); | ||
var ast = parser.parse(file); | ||
|
||
console.log(JSON.stringify(ast, null, " ")); | ||
console.log(JSON.stringify(ast, null, " ")); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is rather a bug because when
--check
is provided, it will still exit after checking only"plugin"
data. Removed after refactor. So it can continue checkingcorejs2-builtin-in
after the first check succeeds.