Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update compat-data related docs/config [skip ci] #11030

Merged
merged 3 commits into from Jan 20, 2020
Merged

update compat-data related docs/config [skip ci] #11030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a87d00e
ignore compat-data build
JLHwung Jan 17, 2020
51a41a7
ignore CONTRIBUTING.md when publishing preset-env
JLHwung Jan 17, 2020
1b61886
docs: update preset-env CONTRIBUTING.md
JLHwung Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintignore
View file
Open in desktop
Expand Up @@ -17,9 +17,9 @@ codemods/*/lib
codemods/*/dist
codemods/*/test/fixtures
codemods/*/test/tmp
packages/babel-compat-data/build
packages/babel-preset-env/data/[^(plugin-features|shipped-proposals).js]
packages/babel-preset-env/test/debug-fixtures
packages/babel-preset-env/build
packages/babel-preset-env-standalone/babel-preset-env.js
packages/babel-preset-env-standalone/babel-preset-env.min.js
packages/babel-standalone/babel.js
Expand Down
1 change: 1 addition & 0 deletions packages/babel-preset-env/.npmignore
View file
Open in desktop
Expand Up @@ -16,3 +16,4 @@ flow-typed
.github
.idea
/build
CONTRIBUTING.md
15 changes: 3 additions & 12 deletions packages/babel-preset-env/CONTRIBUTING.md
View file
Open in desktop
Expand Up @@ -63,25 +63,16 @@ If you want to mark a new proposal as shipped, add it to [this list](https://git

### Update [`plugins.json`](https://github.com/babel/babel/blob/master/packages/babel-preset-env/data/plugins.json)

Until `compat-table` is a standalone npm module for data we are using the git commit in `scripts/download-compat-table.sh`
Until `compat-table` is a standalone npm module for data we are using the git commit in `packages/babel-compat-data/scripts/download-compat-table.sh`

`COMPAT_TABLE_COMMIT=[latest-commit-hash]`,

So we update and then run `npm run build-data`. If there are no changes, then `plugins.json` will be the same.

## Tests

### Running tests locally

```bash
npm test
```

### Checking code coverage locally

```bash
npm run coverage
```
### Running tests
See general [CONTRIBUTING.md](https://github.com/babel/babel/blob/master/CONTRIBUTING.md#running-lintingtests).

### Writing tests

Expand Down