Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps and babel-eslint-* package.jsons #11069

Closed
wants to merge 1 commit into from
Closed

Update deps and babel-eslint-* package.jsons #11069

wants to merge 1 commit into from

Conversation

kaicataldo
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Noticed that these need to be updated!

nicolo-ribaudo
nicolo-ribaudo approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@kaicataldo
Copy link
Member Author

Whoops, looks like I'll need to update some tests

@kaicataldo
Copy link
Member Author

Hmmm actually I don't think we want to do this yet. I'm having trouble getting @babel/eslint-parser to be installed at the top level. It looks like https://github.com/typescript-eslint/typescript-eslint does this, so we'll have to look into how they do it.

@kaicataldo kaicataldo closed this Jan 30, 2020
@kaicataldo
Copy link
Member Author

Moved these changes into #11070 because they're interdependent.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: eslint outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaicataldo @nicolo-ribaudo